Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncrustify checks in JenkinsFile #77

Open
abhijit-mahajani-imgtec opened this issue Mar 3, 2017 · 2 comments
Open

Add uncrustify checks in JenkinsFile #77

abhijit-mahajani-imgtec opened this issue Mar 3, 2017 · 2 comments

Comments

@abhijit-mahajani-imgtec
Copy link

abhijit-mahajani-imgtec commented Mar 3, 2017

As mentioned in https://github.com/contiki-os/contiki/blob/master/CONTRIBUTING.md#code-formatting, we can add uncrustify checks either in git pre-commit hooks but still it would be better to have the check in Jenkinsfile too so that it gets caught in CI.

@Shpinkso Shpinkso removed this from the Clicker Upstreaming milestone Mar 3, 2017
@Shpinkso
Copy link

Shpinkso commented Mar 3, 2017

Need some acceptance criteria in this ticket

@mtusnio
Copy link
Member

mtusnio commented Mar 9, 2017

Check here - https://github.com/CreatorDev/contiki/tree/3.0-mikro-e/tools/code-style - for all the tools to fix/check for issues. I think the acceptance criteria could be as follows:

  • Fix all issues with uncrustify in the files we have changed in cpu/pic32 & platform/mikro-e
  • Add uncrustify checks to the Jenkinsfile for any changed files in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants