-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAYSAT-1551: Fix sorting of product versions in sat showrev --products #287
Conversation
Output from testing on Drax with correctly ordered versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments.
However, using --format json
and --format yaml
is broken and needs to be fixed. It should be a simple fix as we discussed. Take a look at how the XName
class is handled in the SATEncoder
and in SATDumper
in sat.util
.
Output from drax with functional --format json and yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
38b917d
to
e7d9b4b
Compare
e7d9b4b
to
55c494a
Compare
/backport release/3.32 |
Backporting into branch release/3.32 was successful. New PR: #290 |
Summary and Scope
Fixed the sorting of product versions for sat showrev --products as outlined in CRAYSAT-1551
Issues and Related PRs
Testing
Tested on:
Test description:
Tests were run on drax and tested locally, unit tests were also added for the new class.
Risks and Mitigations
Pull Request Checklist