CRAYSAT-1935: create_image_customization_session() missing image_name argument
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` argument Backport `CRAYSAT-1747: Allow passing CFS session name` to SAT 2.6 / CSM 1.5 Incorrect logging is observed in sat bootprep logs SAT is also generating a session name, which is conflicting with session name generated in create_image_customization_session Hence updating the `begin_image_configure` to pass session name to address sat bootprep incorrect logging (cherry picked from commit e35ac28)
annapoorna-s-alt
requested review from
haasken-hpe,
ethanholen-hpe and
vinanti-p
haasken-hpe
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Traceback Error - "TypeError: create_image_customization_session() missing 1 required positional argument: 'image_name'" has been observed with the latest stable build of
release/3.25To fix this, Backport
CRAYSAT-1747: Allow passing CFS session nameto SAT 2.6 / CSM 1.5 as a solutionIncorrect logging is observed in sat bootprep logs SAT is also generating a session name, which is conflicting with session name generated in create_image_customization_session
Hence updating the
begin_image_configureto pass session name to address sat bootprep incorrect logging(cherry picked from commit e35ac28)
Issues and Related PRs
List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.
Testing
List the environments in which these changes were tested.
Tested on:
#rocket
Test description:
How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?
Test the unstable build to create the images successfully from
sat bootprepcommand without any Traceback errorRisks and Mitigations
Are there known issues with these changes? Any other special considerations?
Pull Request Checklist