Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1895: add empty string handling for rootfs_provider key of boot_set #283

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ethanholen-hpe
Copy link
Contributor

@ethanholen-hpe ethanholen-hpe commented Nov 7, 2024

Summary and Scope

This PR adds validation to check that rootfs_provider and rootfs_provider_passthrough are not empty strings

Issues and Related PRs

Testing

Tested on:

  • drax

Test description:

Changes were successful, output of testing on drax: https://gist.github.com/ethanholen-hpe/7069d94e25dc06c59ba84c05c04cfb07#file-gistfile1-txt

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@ethanholen-hpe
Copy link
Contributor Author

ethanholen-hpe commented Nov 12, 2024

@ethanholen-hpe ethanholen-hpe marked this pull request as ready for review November 12, 2024 18:40
@ethanholen-hpe
Copy link
Contributor Author

ethanholen-hpe commented Nov 12, 2024

@haasken-hpe
Copy link
Contributor

haasken-hpe commented Nov 12, 2024

When you squash your commits prior to merging, please use a format like the following for your commit message:

<JIRA_ISSUE_ID>: Short description of change

Longer description of change.

See other commits in this repo for an example. I also have a local Git prepare-commit-msg hook that automatically populates the commit message with the Jira ID from the branch. I can share that with you if you're interested.

As far as what makes a good commit message, I like to refer people to these guidelines. I don't care too much about the strict line length limits, especially for the subject line, but I agree with the other points.

Copy link
Contributor

@annapoorna-s-alt annapoorna-s-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can we update the unit tests as well?

…ot_set

Add a validation method that ensures rootfs_provider and
rootfs_provider_passthrough are not empty
@ethanholen-hpe ethanholen-hpe merged commit 6fd9641 into main Nov 19, 2024
3 checks passed
@ethanholen-hpe ethanholen-hpe deleted the CRAYSAT-1895 branch November 19, 2024 17:30
@ethanholen-hpe
Copy link
Contributor Author

/backport release/3.32

Copy link

Backporting into branch release/3.32 was successful. New PR: #289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants