-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRAYSAT-1895: add empty string handling for rootfs_provider key of boot_set #283
Conversation
77a34b2
to
893065a
Compare
Testing output on Drax: https://gist.github.com/ethanholen-hpe/7069d94e25dc06c59ba84c05c04cfb07#file-gistfile1-txt |
Testing output without change on drax: https://gist.github.com/ethanholen-hpe/16af8f07515668d0ea78ec3ae17d0206 |
When you squash your commits prior to merging, please use a format like the following for your commit message:
See other commits in this repo for an example. I also have a local Git As far as what makes a good commit message, I like to refer people to these guidelines. I don't care too much about the strict line length limits, especially for the subject line, but I agree with the other points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Can we update the unit tests as well?
…ot_set Add a validation method that ensures rootfs_provider and rootfs_provider_passthrough are not empty
4e6d11c
to
3157b9d
Compare
/backport release/3.32 |
Backporting into branch release/3.32 was successful. New PR: #289 |
Summary and Scope
This PR adds validation to check that rootfs_provider and rootfs_provider_passthrough are not empty strings
Issues and Related PRs
Testing
Tested on:
Test description:
Changes were successful, output of testing on drax: https://gist.github.com/ethanholen-hpe/7069d94e25dc06c59ba84c05c04cfb07#file-gistfile1-txt
Pull Request Checklist