CRAYSAT-1929: Fix CFS fields in sat status for CFS v3
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
requested review from
shivaprasad-metimath,
annapoorna-s-alt and
vinanti-p
haasken-hpe
force-pushed
the
CRAYSAT-1929-fix-sat-status-cfs-fields
branch
from
b88ef31
to
d781968
Compare
The `CFSStatusModule` still had hard-coded property names for the properties of a CFS component, and these property names were only valid for CFS v2, so `sat status` only showed CFS fields when CFS v2 was used. Update the mapping so that it correctly maps CFS properties to the `sat status` column names for both CFS v2 and v3. Test Description: Built `cray-sat` image and tested on `noname` with both CFS versions, that is: * `sat status --cfs-version v2` * `sat status --cfs-version v3`
haasken-hpe
force-pushed
the
CRAYSAT-1929-fix-sat-status-cfs-fields
branch
from
d781968
to
829ba2c
Compare
|
Testing results: https://gist.github.com/haasken-hpe/c84a5a18aaf4a5988babcb3baa2bcf2f |
annapoorna-s-alt
approved these changes
Oct 30, 2024
shivaprasad-metimath
approved these changes
Oct 30, 2024
|
/backport release/3.32 |
|
Backporting into branch release/3.32 was successful. New PR: #281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
The
CFSStatusModulestill had hard-coded property names for the properties of a CFS component, and these property names were only valid for CFS v2, sosat statusonly showed CFS fields when CFS v2 was used. Update the mapping so that it correctly maps CFS properties to thesat statuscolumn names for both CFS v2 and v3.Issues and Related PRs
Testing
Tested on:
Test description:
Built
cray-satimage and tested onnonamewith both CFS versions, that is:sat status --cfs-version v2sat status --cfs-version v3Risks and Mitigations
Low risk change which only affects
sat status.Pull Request Checklist