Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMHMS-6140: Parse Managers .Actions correctly for Gigabyte and Paradise platforms during discovery #158

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

jwlv
Copy link
Contributor

@jwlv jwlv commented Jul 23, 2024

Summary and Scope

River platforms Gigabyte and Paradise use the redfish endpoint /redfish/v1/Managers//ResetActionInfo to provide the allowable reset actions for the BMC rather than .Actions in the /redfish/v1/Managers/ redfish endpoint that HP platforms use. Systems discovery in SMD actually supports either .Actions or /ResetActionInfo so the change here for Managers discovery is to mimic what we do for Systems discovery for processing these redfish endpoints.

Also updated the Gigabyte unit tests to include testing the new /ResetActionInfo processing during discovery. The Paradise unit testing will be added as part of CASMHMS-6178.

Issues and Related PRs

Testing

Tested on:

  • drax (for Gigabyte testing)
  • tyr (for Paradise testing)

Test description:

Ran discover against target BMCs and verified that afterwards the correct "[email protected]" values now appeared in 'cray hsm inventory componentEndpoints list' output when run against the target BMCs.

In order for PCS to read the new "supportedPowerTransitions" in 'cray power status describe' output, the PCS deployment must be restarted or the slot the blades are in must be power cycled. I restarted to PCS deployment and verified afterwards that the correct supported transitions then appeared.

Using PCS I targeted both Gigabyte and Paradise BMCs with a soft-restart while logged into the BMC. The ssh session terminated (as expected), and after the BMC rebooted I logged in and checked 'uptime' to verify that the BMC had indeed rebooted.

Ran discover against an HPE River BMC to verify .Actions still processed correctly for non-Paradise and non-Gigabyte BMCs.

Verified that HMS smoke and functional tests still past with changes in place.

Did not test CAPMC as CAPMC can only target nodes and not BMCs.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? Y
  • Were continuous integration tests run? If not, why? Y
  • Was upgrade tested? If not, why? Y
  • Was downgrade tested? If not, why? Y

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jwlv jwlv requested review from a team as code owners July 23, 2024 17:54
Copy link

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.11.17-20240723175505.a1dfddd

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.11.17-20240723175505.a1dfddd

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.11.17-20240723175505.a1dfddd

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.11.17-20240723175505.a1dfddd > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of 8a56bdd and the PR base branch. Good luck and make rocket go now! 🌮 🚀

Copy link

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd:2.11.17-20240723175458.a1dfddd

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd:2.11.17-20240723175458.a1dfddd

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd:2.11.17-20240723175458.a1dfddd

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd:2.11.17-20240723175458.a1dfddd > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of 8a56bdd and the PR base branch. Good luck and make rocket go now! 🌮 🚀

@jwlv jwlv merged commit 25f0e05 into release/2.11 Jul 25, 2024
15 checks passed
@jwlv jwlv deleted the CASMHMS-6140.1.5 branch July 25, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants