CASMHMS-6140: Parse Managers .Actions correctly for Gigabyte and Paradise platforms during discovery #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
River platforms Gigabyte and Paradise use the redfish endpoint /redfish/v1/Managers//ResetActionInfo to provide the allowable reset actions for the BMC rather than .Actions in the /redfish/v1/Managers/ redfish endpoint that HP platforms use. Systems discovery in SMD actually supports either .Actions or /ResetActionInfo so the change here for Managers discovery is to mimic what we do for Systems discovery for processing these redfish endpoints.
Also updated the Gigabyte unit tests to include testing the new /ResetActionInfo processing during discovery. The Paradise unit testing will be added as part of CASMHMS-6178.
Issues and Related PRs
Testing
Tested on:
Test description:
Ran discover against target BMCs and verified that afterwards the correct "[email protected]" values now appeared in 'cray hsm inventory componentEndpoints list' output when run against the target BMCs.
In order for PCS to read the new "supportedPowerTransitions" in 'cray power status describe' output, the PCS deployment must be restarted or the slot the blades are in must be power cycled. I restarted to PCS deployment and verified afterwards that the correct supported transitions then appeared.
Using PCS I targeted both Gigabyte and Paradise BMCs with a soft-restart while logged into the BMC. The ssh session terminated (as expected), and after the BMC rebooted I logged in and checked 'uptime' to verify that the BMC had indeed rebooted.
Ran discover against an HPE River BMC to verify .Actions still processed correctly for non-Paradise and non-Gigabyte BMCs.
Verified that HMS smoke and functional tests still past with changes in place.
Did not test CAPMC as CAPMC can only target nodes and not BMCs.
Pull Request Checklist