-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Http headers are not applied on non-queued requests on iOS #298
Comments
Hi @sbatezat, |
presentableFeedbacks is empty, and retrievedWidgets (= await _channel.invokeMethod('getAvailableFeedbackWidgets')) is too |
Thank you for checking that. I’ll investigate this issue and get back to you soon. |
Maybe because, according to this changelog, getFeedbackWidget is deprecated on iOS ? |
Good observation! However, since the deprecated method uses the same underlying implementation as |
Could you please print or check the values of |
It seems possible that the user you're checking on iOS may have already completed or submitted the available feedback, which could be why no new feedback is being retrieved. Could you try testing with a different device ID? |
Unfortunately, I've got only one iOS device. |
Each user has a unique device ID. When feedback is submitted, the server marks it as completed and only returns feedbacks that hasn't been completed yet for that user. Since you mentioned having only one iOS device, you can try reinstalling the app. This will automatically assign a new device ID if you're not explicitly providing one during initialization or changing it after initialization. If you want to change the device ID without merging, you can use the In new versions we have added |
I've got tons of "multiple" feedback for the same user (i'm setting a custom ID), it's working fine (until now, and just broken only on iOS) and it's "my" expected behavior. |
Could you please try with different device ID? |
Same behavior: a list of available widgets (1) on Android, but an empty list on iOS. |
There are three types of feedback widgets (Survey, NPS, and Ratings) |
Ok! All good on that side 👍 With the same source code, it's working on Android and not on iOS for my app. |
Rating widgets also have the option to set targeting users, could you please verify the targeting users of your rating widget on dashboard? |
It's set on "all users". |
To help diagnose the issue further, could you please try accessing the following URL in your browser by replacing the placeholders with your actual server URL, app key, and device ID? https://YOUR_SERVER_URL/o/sdk?method=feedback&app_key=YOUR_APP_KEY&device_id=YOUR_DEVICE_ID Please check the response using both your iOS and Android device IDs separately and share the results. This will help us understand if the server is returning the correct feedback widgets for each device. |
My device id is the same for both Android & iOS, so I'll have only one result. Here it is:
|
Great!, response looks ok |
My device id is the same for both Android & iOS for months |
The request seems to be fine. I've found the origin. There is an error field populated on iOS part but not on Flutter side. I'm looking for request details to see if my custom header (needed by my API Management) is set, but probably not. |
Ok, I can confirm it's an issue with #284 There is a "nil" on NSURLSession.sharedSession.configuration.HTTPAdditionalHeaders... Of course, I've called |
@ijunaid could you please confirm it's an iOS issue and ask the iOS team to fix it? Whatever, I keep this issue opened, as Flutter Countly is using a deprecated method AND do not log iOS error on that case |
@sbatezat, thanks for the update. I’ll discuss this internally with the team and work on fixing the issue. |
@ijunaid do you have any feedback about this? Did the iOS team tell you when they will work on this? |
Hi @ijunaid |
Hi @sbatezat |
Thank you both for these quick answers! Good luck |
Sorry to ask again, is it still planned for this week? |
Hi @sbatezat , yes we plan to release today if everything goes according to the plan. We have some new server features for which had to hold back and keep testing. |
@sbatezat just released 24.11.1 |
Thanks; I did the update and it's working as expected.
From #298 (comment) |
AvailableFeedbackWidgets not working anymore on iOS
empty is returning false on Android (this is ok) and true on iOS
It was working previously and I'm still looking for the root cause...
The text was updated successfully, but these errors were encountered: