Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug Random.NextBytes(Span<byte> buffer) #3051

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Plug Random.NextBytes(Span<byte> buffer) #3051

merged 2 commits into from
Aug 9, 2024

Conversation

Guillermo-Santos
Copy link
Contributor

No description provided.

@Guillermo-Santos
Update RandomImpl.cs
37b8f67 
Implement Random.NextBytes(Span<byte> buffer)
@Guillermo-Santos Guillermo-Santos changed the title Implement Random.NextBytes(Span<byte> buffer) Plug Random.NextBytes(Span<byte> buffer) Jul 28, 2024
@Guillermo-Santos
Copy link
Contributor Author

Since this is basically a copy of Random.NextBytes(bytes[] buffer) i wonder if i should also change that one to make a call to this one.

@zarlo
Copy link
Member

zarlo commented Aug 5, 2024

Since this is basically a copy of Random.NextBytes(bytes[] buffer) i wonder if i should also change that one to make a call to this one.

if you want to do this i can wait to merge it in

@MishaProductions MishaProductions merged commit 4f720d4 into CosmosOS:master Aug 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarlo zarlo zarlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guillermo-Santos @zarlo @MishaProductions