Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code #36

Open
6 tasks
HatemMn opened this issue Nov 18, 2024 · 0 comments
Open
6 tasks

Dead code #36

HatemMn opened this issue Nov 18, 2024 · 0 comments

Comments

@HatemMn
Copy link
Collaborator

HatemMn commented Nov 18, 2024

  • Install Knip ( similar to ai client repo )
  • Check for dead code, delete it
  • test that nothing breaks
  • this comment :
    General thoughts :

Those files under public/actions

They should have never been committed to the repo, they should be copied in Vite's config at build time and be ignored when committing

I will add this to one of the repo issues to update it, it should make reviews less verbose for us and avoid linters & co catching those files

  • npm install takes a lot of time, investigate
  • fix this : on npm install
    image
@HatemMn HatemMn mentioned this issue Nov 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant