Preparation of Findex v7 #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: rebuild
chloehebant
reviewed
Feb 23, 2024
Comment on lines
+34
to
+35
| /// | ||
| /// Returns the restriction of the stored DX to the conflicting tags. |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// Returns the restriction of the stored DX to the conflicting tags. |
There was a problem hiding this comment.
I will keep this, since this is what the insert returns.
|
|
||
| pub use structs::{Token, Edx}; | ||
|
|
||
| pub trait EdxDbInterface { |
There was a problem hiding this comment.
Why not a DbInterface instead of EdxDbInterface?
There was a problem hiding this comment.
To underline the fact that Vera stores the EDX in the shape of an EDX, while Findex stores an EMM as two EDXes.
This was also a good way to comfort me in moving the definition of the EDX to the DB module.
Co-authored-by: chloehebant <[email protected]>
Co-authored-by: chloehebant <[email protected]>
Co-authored-by: chloehebant <[email protected]>
Co-authored-by: chloehebant <[email protected]>
Co-authored-by: chloehebant <[email protected]>
- add benches - add useful macros - correct some errors
This is okay since this version is not to be released. It is only the paper's supporting version. The graph functionality is missing, which changes all interface arguments (no `IndexedValue`). The tests removed in this commit are to be re-written upon v7 release. Also care was taken to write (both sequential and concurrent) tests for each scheme implemented in this repo. So I have a good confidence about their correctness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR, I write the core logic of Findex v7 (the one described in the Findex paper).
The graph and index interfaces from Findex v6 are not updated and therefore do not compile.
Tests can be run using
cargo test --features in_memory.