Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue #151

Closed
Swelem opened this issue Oct 6, 2017 · 9 comments
Closed

Compatibility issue #151

Swelem opened this issue Oct 6, 2017 · 9 comments

Comments

@Swelem
Copy link

Swelem commented Oct 6, 2017

Hey, so there are a lot of compatibility issues with tough as nails like:
Rain collectors only fill up if vanilla says rain and don't respond to weather2 rain
In winter, snow doesn't fall from the sky and if vanillarain=true then snow will begin to cover the ground without weather2 rain and if it does rain its not snow.

The problem is that Tough as nails only responds to vanilla weather not weather2 weather and that weather2 doesn't act on tough as nails modified temperatures.

To sum it up weather2 weather doesn't affect tough as nails.
Thank you for fixing this in advance

@Swelem Swelem changed the title Compatibility issu Compatibility issue Oct 6, 2017
@Gunner76th
Copy link

Expanding on this issue, other mods such as Forestry are not seeing that the rain event is being triggered. Case in point is the image upload of the Forestry rain tank. I set /weather2 storm create rain, but yet the tank (Forestry) is saying there is no rain.

It seems that the problem lies in how Weather 2 is triggering/registering weather for each area. This is a major issue as this affects every mod out there that relies on weather event triggers.
2017-10-12_18 24 46

@Corosauce
Copy link
Owner

Pop open the Weather config GUI, set the 'rains when' setting to 'global overcast', will fix issue but also make my stuff only active when vanilla rain rules decide to rain. Looking to make a more universal solution soon.

@Swelem
Copy link
Author

Swelem commented Oct 15, 2017

Yea but still when its winter, the snow accumulates but falls from the sky as rain and to be honest, Overcast mode ruins weather2

@MasterJochen
Copy link

Hey im using Harder Wildlife cause it has seasons. BTW I love weather 2 mod im using version 1.7.10
I gues i understand the problem. Im just asking if you could activate in overcastmode the rain/snow visuals cause it loooks wierd when snow piles up without snowflakes falling from the sky. So global visual would be a fix.

  1. option Have Weather 2 and minecraft weather doing both there stuff so if server says rain minecraft let it rain and snow will pile up with visuals.

2 option 2 would be cooler Have snow in Harder Wildlife season only at that positions pile up where the storm/ rain is. Weather 2 does not pile up snow at all in the winter in the PLAINS

I hope this project is not dead i would love to see a fix ore some help

@Corosauce
Copy link
Owner

I cant even find a github repo for that Harder Wildlife mod so I doubt it has any api to make it easier to work with. Was fiddling with better vanilla support recently but more issues cropped up, holding off idea of PR for forge for that, might coremod to improve things but coremodding is going to change entirely in next 2 months so I think I'll wait till 1.13 forge drops.

Maybe ill try to support TANs api for now, hmm.

@EngineOfDarkness
Copy link

Maybe this helps? I faintly remember Draco18s is working on it

I seem to remember Harder Wildlife not being available on newer Minecraft Versions, he has another repository (Reasonable Realism) without it - so maybe you should talk to him before doing any work to save yourself some hassle.

@Corosauce
Copy link
Owner

Ah thanks for the link, missed that, if he actually updates to a modern mc version I might poke around for more compat.

@EngineOfDarkness
Copy link

Just checked, Harder Farming (which is a stripped down version of Harder Wildlife) is available for 1.12.1

Someone also opened an issue on on Draco18s Repository aswell Draco18s/ReasonableRealism#19

I haven't checked ingame, but according to the Wiki-Section of Harder Farming there might be the following features which may require some cross-compatability (on first glance, at least, and without me having checked ingame)

@Corosauce
Copy link
Owner

Corosauce commented Dec 31, 2017

Ah cool, thanks for the info, in the meantime:

I've now got the visual of precipitation and block based snow buildup matching the temperatures for tough as nails Corosauce/CoroUtil@1981d17

For vanilla rain/snow based issues, global overcast is still the recommended compromise to those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants