-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(layout) Adjust new note button on mobile #182
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Thanks for addressing this point! But we can also replace the creation button with an icon |
Good idea! I'll work on this over the weekend. |
Not sure what SonarCloud is complaining about? Is this okay to ignore or shoud I use className instead? |
Yeah you may ignore the |
957e085
to
ff72fa9
Compare
Hope you're happy with the way I've implemented it, let me know if there's any revisions you would like me to make. For the translations, should I leave them blank or use Google translate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr, it's what I add in mind 💪
Before merging can you
- remove the empty keys from other languages, since when a key is missing (not empty) it'll fallback to the default language
- keep the text in the button in mobile, since all the icons are gone on mobile, we have the needed room to keep it with text
Thanks again 🙏
This reverts commit 37c63c8.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you 🙏
Currently on mobile devices the nav bar is pretty full:

I was thinking how to make this slightly tidier, and tried hiding the text:

@CorentinTh Any suggestions of a better way to do this or would you rather just keep it with the text?