Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable HTTPS without reverse proxy #371

Closed
3 tasks done
fanyangto opened this issue Dec 5, 2024 · 1 comment · Fixed by #376
Closed
3 tasks done

enable HTTPS without reverse proxy #371

fanyangto opened this issue Dec 5, 2024 · 1 comment · Fixed by #376
Assignees
Labels
enhancement New feature or request

Comments

@fanyangto
Copy link

fanyangto commented Dec 5, 2024

What type of request is this?

Enhancement of an existing feature

Clear and concise description of the feature you are proposing

I am generally familiar with openssl and PKI operations to create server certs. Is there a way/documentation on how to enable HTTPS on Enclosed app without putting a reverse proxy in front of it ? I find the documentation lacking in this regard. We probably need a few pointers on how to do this, and we can run along on our own.

Ideally, the Enclose app should support HTTPS on its own, with the cert/keystore passed in to the docker environment. It could even deploy a self-signed cert, until the user has the time to replace it with a proper cert chain.

This would be so much better than upon the first docker deployment, the page is basically unusable due to the lack of HTTPS.

Additional context

No response

Validations

  • Check the feature is not already implemented in the project.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
  • Check that the feature is technically feasible and aligns with the project's goals.
@CorentinTh
Copy link
Owner

CorentinTh commented Dec 19, 2024

Hey @fanyangto

Just added native HTTPS support in #376 with either cert + key or pfx + passphrase
It's available for enclosed version >= 1.14

You can see the added configuration variable in the config page, and a dedicated explanation here: https://docs.enclosed.cc/self-hosting/configuration#optional-native-https-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants