-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF4 #88
base: master
Are you sure you want to change the base?
SF4 #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, thank you !
Can you update the ReadMe too ?
use Symfony\Component\HttpFoundation\Request; | ||
use Symfony\Component\HttpFoundation\Response; | ||
use Symfony\Component\Templating\EngineInterface; | ||
use Twig_Environment; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twig_Environment \Twig_Environment
@@ -72,7 +72,7 @@ private function getApplication(InputInterface $input) | |||
} | |||
|
|||
/** | |||
* @return KernelInterface | |||
* @return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the TypeHint ?
@@ -31,4 +31,8 @@ public function getName() | |||
{ | |||
return 'coresphere_console'; | |||
} | |||
|
|||
public function reset(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CS, be careful to PSR
public function reset()
{
}
"symfony/event-dispatcher": "~2.7|~3.0|~4.0", | ||
"symfony/framework-bundle": "~2.7|~3.0|~4.0", | ||
"symfony/http-kernel": "~2.7|~3.0|~4.0" | ||
"symfony/console": "~2.7|~4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you that this modification works with SF <= 3.4 ?
No description provided.