Added more credit cards inside cards.js #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cacontinuos check it out |
Comment on lines
+203
to
+211
| name: 'Santander', | ||
| bins: /^4\d{15}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Caixa Econômica Federal', | ||
| bins: /^627\d{13,16}$/, | ||
| codeLength: 3, | ||
| }, |
There was a problem hiding this comment.
@vr-varad, are all these new registrations card brands? From what I noticed, Santander and Caixa Econômica Federal are banks and not card brands.
Comment on lines
+67
to
+211
| { | ||
| name: 'UnionPay International', | ||
| bins: /^(62[1-5]|81[0-9])\d{14,17}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Carte Blanche', | ||
| bins: /^389[0-9]{11}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Laser', | ||
| bins: /^(6304|6706|6771|6709)\d{8,15}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Eurocard', | ||
| bins: /^(4596|4312|4317|4388)\d{12}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Carta Si', | ||
| bins: /^432917\d{10}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'ECMC', | ||
| bins: /^5[45][0-9]{14}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Visa Electron', | ||
| bins: /^4(026|17500|405|508|844|913|917)\d{10,13}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'UATP', | ||
| bins: /^1\d{14}$/, | ||
| codeLength: 4, | ||
| }, | ||
| { | ||
| name: 'Banamex', | ||
| bins: /^52[2-9]\d{14}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Bancomer', | ||
| bins: /^53[0-9]\d{14}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'KoreanCard', | ||
| bins: /^9[0-9]{15}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'N26', | ||
| bins: /^5355\d{14}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Revolut', | ||
| bins: /^5398\d{14}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Starbucks Card', | ||
| bins: /^62\d{17}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Woori Card', | ||
| bins: /^6[0-9]{18}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Shinhan Card', | ||
| bins: /^9[0-9]{16}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Sberbank', | ||
| bins: /^4276\d{12}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Alfa-Bank', | ||
| bins: /^4154\d{12}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Santander', | ||
| bins: /^4\d{15}$/, | ||
| codeLength: 3, | ||
| }, | ||
| { | ||
| name: 'Caixa Econômica Federal', | ||
| bins: /^627\d{13,16}$/, | ||
| codeLength: 3, | ||
| }, |
There was a problem hiding this comment.
Can you add tests in credicard.test.js file?
There was a problem hiding this comment.
tests as in can u briefly explain it would be helpful
There was a problem hiding this comment.
If you notice file credicard.test.js contains tests to ensure getCreditCardNameByNumber method works correctly. Ideally, tests should be added for each new card.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added as many cards as I found that are highly used worldwide.