Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for enabling non-default metric categories and defaults in a easier way #7681

Open
lucassaldanha opened this issue Nov 8, 2023 · 2 comments

Comments

@lucassaldanha
Copy link
Member

lucassaldanha commented Nov 8, 2023

Currently, if I want to enable a non-default metric category, but keep all default metrics enabled, my only option is to use --metrics-categories=A,B,C,D,...,X (all default categories plus the non-default category I want to use).

It would be great if I had the option of just enabling all default categories + the extra non-default categories I want.

Something like:
teku --metrics-enabled --metrics-default-categories-enabled --metrics-categories=X

--metrics-default-categories-enabled default value is true.

Another idea:
teku --metrics-enabled --metrics-categories=DEFAULT,X
Using an "alias" for default metrics.

@lucassaldanha lucassaldanha self-assigned this Nov 8, 2023
@benjaminion
Copy link
Contributor

Currently our docs say that all categories are enabled by default. Is that not correct?

My preference would be for the --metrics-categories=DEFAULT,X version with the alias.

@lucassaldanha
Copy link
Member Author

I have opened a PR to update our docs re non-default categories. Consensys/doc.teku#521

@lucassaldanha lucassaldanha removed their assignment Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants