From 1028ebd086ff5baecc634623041b010f43d7bdb8 Mon Sep 17 00:00:00 2001
From: Amine Harty <amine.harty@consensys.net>
Date: Wed, 28 Feb 2024 01:45:48 +0100
Subject: [PATCH] feat: gha change node version and fix sonarcloud (#200)

---
 .github/workflows/build-test.yml                    | 6 +++---
 .github/workflows/deploy-dev.yml                    | 2 +-
 .github/workflows/deploy.yml                        | 2 +-
 .github/workflows/e2e-tests-slack-notifications.yml | 2 +-
 .github/workflows/e2e-tests.yml                     | 2 +-
 .github/workflows/publish-npm-dev.yml               | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
index 2af2f579..6f460c7f 100644
--- a/.github/workflows/build-test.yml
+++ b/.github/workflows/build-test.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-20.04
     strategy:
       matrix:
-        node-version: [16.x]
+        node-version: [20.x]
     steps:
       - uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}
@@ -39,14 +39,14 @@ jobs:
       - run: yarn lint
       - run: yarn test
       - name: SonarCloud Scan Starknet-Snap
-        uses: SonarSource/sonarcloud-github-action@v1.9.1
+        uses: SonarSource/sonarcloud-github-action@v2.1.1
         with:
           projectBaseDir: packages/starknet-snap/
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN_STARKNET_SNAP }}
       - name: SonarCloud Scan Wallet-UI
-        uses: SonarSource/sonarcloud-github-action@v1.9.1
+        uses: SonarSource/sonarcloud-github-action@v2.1.1
         with:
           projectBaseDir: packages/wallet-ui/
         env:
diff --git a/.github/workflows/deploy-dev.yml b/.github/workflows/deploy-dev.yml
index 89639028..7e3da9f8 100644
--- a/.github/workflows/deploy-dev.yml
+++ b/.github/workflows/deploy-dev.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 20.x
 
       - name: Get Yarn cache directory
         run: echo "::set-output name=YARN_CACHE_DIR::$(yarn cache dir)"
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index f1ba0934..ccd5d654 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -25,7 +25,7 @@ jobs:
       - name: Use Node.js 16.x
         uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 20.x
           registry-url: 'https://registry.npmjs.org'
       - name: Get Yarn cache directory
         run: echo "::set-output name=YARN_CACHE_DIR::$(yarn cache dir)"
diff --git a/.github/workflows/e2e-tests-slack-notifications.yml b/.github/workflows/e2e-tests-slack-notifications.yml
index 81025147..42dcbb24 100644
--- a/.github/workflows/e2e-tests-slack-notifications.yml
+++ b/.github/workflows/e2e-tests-slack-notifications.yml
@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 20.x
      
       - name: Install dependencies
         run: cd e2e && yarn install --frozen-lockfile
diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml
index cb5547b7..5f113aaf 100644
--- a/.github/workflows/e2e-tests.yml
+++ b/.github/workflows/e2e-tests.yml
@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v2
         with:
-          node-version: 16.x
+          node-version: 20.x
      
       - name: Install dependencies
         run: cd e2e && yarn install --frozen-lockfile
diff --git a/.github/workflows/publish-npm-dev.yml b/.github/workflows/publish-npm-dev.yml
index 2ede5aa5..e87584f8 100644
--- a/.github/workflows/publish-npm-dev.yml
+++ b/.github/workflows/publish-npm-dev.yml
@@ -28,7 +28,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.x'
+          node-version: '20.x'
           registry-url: 'https://registry.npmjs.org'
       - run: npm publish ./packages/starknet-snap --tag dev --access public
         env: