Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing coordinator.zip file in Docker build process #193

Open
nadeemb53 opened this issue Oct 16, 2024 · 1 comment
Open

Missing coordinator.zip file in Docker build process #193

nadeemb53 opened this issue Oct 16, 2024 · 1 comment

Comments

@nadeemb53
Copy link
Contributor

nadeemb53 commented Oct 16, 2024

Impact

environment [Testnet/Mainnet]: Testnet

an user is impacted [Y/N], if yes type of user: [External/Internal]: Y, Internal

Describe the bug

The coordinator.zip file, which is required for building the coordinator Docker image, is missing from the build context. This prevents the successful creation of the coordinator Docker image, which is crucial for deploying and running the coordinator service.

Steps to Reproduce

  1. Navigate to the coordinator directory in the linea-monorepo
  2. Run the Docker build command: docker build -t coordinator .
  3. Observe the build failure due to missing coordinator.zip file

Actual result

The Docker build fails with the following error:
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref 3d749274-78a5-4b2b-9753-8071189e5e92::w1ikosfgykiccu4hwnpsqozfj: "/coordinator.zip": not found

Expected result

The coordinator.zip file should be present in the build context, allowing the Docker build process to successfully copy and unzip it as specified in the Dockerfile.

Additional context

  • The Dockerfile expects coordinator.zip to be in the same directory or accessible within the build context.
  • It's unclear where this file should come from or how it should be generated.
  • This issue blocks the deployment and testing of the coordinator service in containerized environments.

Proposed solution

  1. Clarify the source of the coordinator.zip file (e.g., build artifact, pre-built resource).
  2. Update the documentation or build process to ensure the file is generated or placed in the correct location before the Docker build.
  3. Consider modifying the Dockerfile to handle cases where the zip file might not be present (e.g., downloading from a known location or generating it as part of the build process).

Finally, I believe the documentation for running the coordinator unit tests is missing from the monorepo.

@jonesho
Copy link
Contributor

jonesho commented Nov 19, 2024

FYI, you can take a look at this workflow file to get an idea of the docker image building process for coordinator, which requires the gradle command ./gradlew coordinator:app:distZip --no-daemon to be run beforehand to build the coordinator.zip and pass it as build context to the docker image build command, but I agree that a better documentation is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants