From 16fbcd9547eb0b4add7d9d86c217f89d0da9b239 Mon Sep 17 00:00:00 2001
From: Soleimani193 <azam.soleimanian@ens.fr>
Date: Mon, 2 Dec 2024 09:48:18 +0100
Subject: [PATCH] added aggregator

---
 .../distributed/compiler/global/global.go     |  7 ++++
 .../distributed/compiler/local/local.go       |  7 ++++
 prover/protocol/distributed/distributed.go    | 33 ++++++++++++++-----
 3 files changed, 39 insertions(+), 8 deletions(-)
 create mode 100644 prover/protocol/distributed/compiler/global/global.go
 create mode 100644 prover/protocol/distributed/compiler/local/local.go

diff --git a/prover/protocol/distributed/compiler/global/global.go b/prover/protocol/distributed/compiler/global/global.go
new file mode 100644
index 000000000..28a5777b9
--- /dev/null
+++ b/prover/protocol/distributed/compiler/global/global.go
@@ -0,0 +1,7 @@
+package global
+
+import "github.com/consensys/linea-monorepo/prover/protocol/wizard"
+
+func IntoDistributedGlobal(comp *wizard.CompiledIOP) {
+	panic("unimplemented")
+}
diff --git a/prover/protocol/distributed/compiler/local/local.go b/prover/protocol/distributed/compiler/local/local.go
new file mode 100644
index 000000000..a8d0dbfbc
--- /dev/null
+++ b/prover/protocol/distributed/compiler/local/local.go
@@ -0,0 +1,7 @@
+package local
+
+import "github.com/consensys/linea-monorepo/prover/protocol/wizard"
+
+func IntoDistributedLocal(comp *wizard.CompiledIOP) {
+	panic("unimplemented")
+}
diff --git a/prover/protocol/distributed/distributed.go b/prover/protocol/distributed/distributed.go
index 3484bafaa..b4ee11823 100644
--- a/prover/protocol/distributed/distributed.go
+++ b/prover/protocol/distributed/distributed.go
@@ -4,7 +4,9 @@ import (
 	"github.com/consensys/linea-monorepo/prover/maths/field"
 	"github.com/consensys/linea-monorepo/prover/protocol/compiler/mimc"
 	"github.com/consensys/linea-monorepo/prover/protocol/compiler/specialqueries"
+	"github.com/consensys/linea-monorepo/prover/protocol/distributed/compiler/global"
 	"github.com/consensys/linea-monorepo/prover/protocol/distributed/compiler/inclusion"
+	"github.com/consensys/linea-monorepo/prover/protocol/distributed/compiler/local"
 	"github.com/consensys/linea-monorepo/prover/protocol/distributed/compiler/permutation"
 	"github.com/consensys/linea-monorepo/prover/protocol/distributed/compiler/projection"
 	"github.com/consensys/linea-monorepo/prover/protocol/ifaces"
@@ -19,6 +21,7 @@ type DistributedWizard struct {
 	Aggregator         *wizard.CompiledIOP
 }
 
+// DistributedModule implements the utilities relevant to a single segment.
 type DistributedModule struct {
 	LookupPermProj *wizard.CompiledIOP
 	GlobalLocal    *wizard.CompiledIOP
@@ -30,32 +33,40 @@ type ModuleDiscoverer interface {
 	// group best the columns into modules.
 	Analyze(comp *wizard.CompiledIOP)
 	NbModules() moduleName
-	ModuleList() []string
+	ModuleList(comp *wizard.CompiledIOP) []string
 	FindModule(col ifaces.Column) moduleName
 }
 
 // This transforms the initial wizard. So it is not really the initial
 // wizard anymore. That means the caller can forget about "initialWizard"
 // after calling the function.
-func Distribute(initialWizard *wizard.CompiledIOP, disc ModuleDiscoverer) DistributedWizard {
+// maxNbSegment is a large max for the number of segments in a module.
+func Distribute(initialWizard *wizard.CompiledIOP, disc ModuleDiscoverer, maxNbSegments int) DistributedWizard {
 
+	// prepare the  initialWizard for the distribution. e.g.,
+	// adding auxiliary columns or dividing a lookup query to two queries one over T and the other over S.
 	prepare(initialWizard)
+	// it updates the map of Modules-Columns (that is a field of initialWizard).
 	disc.Analyze(initialWizard)
 
-	addSplittingStep(disc, initialWizard) // adds a prover step to "push" all the sub-witness assignment
-
-	moduleLs := disc.ModuleList()
+	moduleLs := disc.ModuleList(initialWizard)
 	distModules := []DistributedModule{}
 
 	for _, modName := range moduleLs {
+		// Segment Compilation;
+		// Compile every dist module with the same sequence of compilation steps for uniformity
 		distMod := extractDistModule(initialWizard, disc, modName)
 		distModules = append(distModules, distMod)
 	}
 
-	// Compile every dist module with the same sequence of compilation steps for uniformity
+	// for each [DistributedModule] it checks the consistency among
+	// its replications where the number of replications is maxNbSegments.
+	aggr := aggregator(maxNbSegments, distModules, moduleLs)
 
 	return DistributedWizard{
-		Bootstrapper: initialWizard,
+		Bootstrapper:       initialWizard,
+		DistributedModules: distModules,
+		Aggregator:         aggr,
 	}
 }
 
@@ -69,12 +80,18 @@ func prepare(comp *wizard.CompiledIOP) {
 	inclusion.IntoLogDerivativeSum(comp)
 	permutation.IntoGrandProduct(comp)
 	projection.IntoGrandSum(comp)
+	local.IntoDistributedLocal(comp)
+	global.IntoDistributedGlobal(comp)
 }
 
-func addSplittingStep(comp *wizard.CompiledIOP) {
+func addSplittingStep(comp *wizard.CompiledIOP, disc ModuleDiscoverer) {
 	panic("unimplemented")
 }
 
 func extractDistModule(comp *wizard.CompiledIOP, disc ModuleDiscoverer, moduleName moduleName) DistributedModule {
 	panic("unimplemented")
 }
+
+func aggregator(n int, idsModules []DistributedModule, moduleNames []string) *wizard.CompiledIOP {
+	panic("unimplemented")
+}