chore(contracts): supportsInterface should make use of inheritance #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
satyajeetkolhapure,
orbmis,
arthur-remy and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #818 +/- ##
===========================================
+ Coverage 48.96% 74.43% +25.46%
===========================================
Files 18 49 +31
Lines 388 888 +500
Branches 61 187 +126
===========================================
+ Hits 190 661 +471
- Misses 195 224 +29
Partials 3 3 ☔ View full report in Codecov by Sentry. |
satyajeetkolhapure
approved these changes
Nov 26, 2024
alainncls
force-pushed
the
chore/supportsinterface-should-make-use-of-inheritance
branch
from
9e9e681 to
3c6e505
Compare
alainncls
force-pushed
the
chore/supportsinterface-should-make-use-of-inheritance
branch
from
3c6e505 to
29b0054
Compare
alainncls
deleted the
chore/supportsinterface-should-make-use-of-inheritance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses inheritance of
ERC165for bettersupportsInterfaceRelated ticket
Fixes #817
Type of change
Check list