Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to be able to call any method on the AttestationRegistry via the SDK #304

Conversation

satyajeetkolhapure
Copy link
Collaborator

@satyajeetkolhapure satyajeetkolhapure commented Oct 19, 2023

What does this PR do?

Related ticket

Fixes #203

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #304 (1999cb7) into dev (484c24d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #304   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          13       13           
  Lines         224      224           
  Branches       53       53           
=======================================
  Hits          205      205           
  Misses         10       10           
  Partials        9        9           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@satyajeetkolhapure satyajeetkolhapure self-assigned this Oct 19, 2023
@alainncls alainncls changed the title feat: As a user, I want to be able to call any method on the AttestationRegistry via the SDK feat: As a user, I want to be able to call any method on the AttestationRegistry via the SDK Oct 23, 2023
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-AttestationRegistry-via-the-SDK branch from b920390 to 50c56c6 Compare October 23, 2023 17:04
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-AttestationRegistry-via-the-SDK branch 2 times, most recently from b42813d to 47b0a8a Compare October 23, 2023 20:25
@alainncls alainncls force-pushed the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-AttestationRegistry-via-the-SDK branch from 47b0a8a to 1999cb7 Compare October 23, 2023 22:14
@satyajeetkolhapure satyajeetkolhapure merged commit 6e593ef into dev Oct 24, 2023
7 checks passed
@satyajeetkolhapure satyajeetkolhapure deleted the feature/as-a-user-i-want-to-be-able-to-call-any-method-on-the-AttestationRegistry-via-the-SDK branch October 24, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to be able to call any method on the AttestationRegistry via the SDK
4 participants