Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Regroup transaction options in a dedicated object #858

Open
alainncls opened this issue Dec 17, 2024 · 0 comments
Open

[TASK] Regroup transaction options in a dedicated object #858

alainncls opened this issue Dec 17, 2024 · 0 comments

Comments

@alainncls
Copy link
Collaborator

At the SDK level, functions crafting transactions have multiple parameters: functional parameters (such as the payload to attest, etc.) and technical parameters (such as a custom ABI, etc.).

Example: the attestV2 function in the PortalDataMapper here.

While the functional parameters are mandatory, the technical parameters are optional and/or have a default value. And at the same time, they generate a long signature for the functions.

The goal of this ticket is to harmonize the technical parameters on all functions generating an on-chain transaction, by introducing a TransactionOptions object regrouping these parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for development
Development

No branches or pull requests

1 participant