Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPACT v1 and v2 common code should be in a common solidity file #150

Open
drinkcoffee opened this issue Oct 24, 2022 · 0 comments
Open

GPACT v1 and v2 common code should be in a common solidity file #150

drinkcoffee opened this issue Oct 24, 2022 · 0 comments

Comments

@drinkcoffee
Copy link
Contributor

GPACTv1 and v2 though different, have some common code. For example, the Segment event is defined identically.

Having duplication of identical code will lead to one being updated and not the other. It also makes it harder for people new to the codebase to understand how GPACT v1 and v2 differ.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drinkcoffee