Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permit qualified names in defun #528

Closed
DavePearce opened this issue Jan 10, 2025 · 0 comments · Fixed by #530
Closed

fix: permit qualified names in defun #528

DavePearce opened this issue Jan 10, 2025 · 0 comments · Fixed by #530
Assignees
@DavePearce
Labels
bug Something isn't working

Comments

@DavePearce
Copy link
Collaborator

The following is currently accepted by corset:

(defun (selector) (+ m1.A m1.B))

(module m1)
(defcolumns A B C)
(deflookup c1 ((selector)) (C))

At the moment, this is rejected by go-corset. An interesting question is whether or not there are any other restrictions.
@DavePearce DavePearce added the bug Something isn't working label Jan 10, 2025
@DavePearce DavePearce self-assigned this Jan 10, 2025
@DavePearce DavePearce linked a pull request Jan 10, 2025 that will close this issue
fix: global access from defun declarations #530
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavePearce DavePearce

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: global access from defun declarations Consensys/go-corset
1 participant
@DavePearce