Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support compilation templates #516

Closed
DavePearce opened this issue Jan 9, 2025 · 1 comment · Fixed by #519
Closed

feat: support compilation templates #516

DavePearce opened this issue Jan 9, 2025 · 1 comment · Fixed by #519
Assignees

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented Jan 9, 2025

The existing corset tool had a notion of a compilation template where it would be given a directory and would compile specific files within this directory. Specifically, when given a directory to compile, the original tool considers each of these sections separately:

  • columns
  • constraints
  • constants
  • lookups

When considering a section section, the tool first looks for a file section.lisp. If that file exists, its included. Otherwise, it looks for a directory section and then includes all files within this directory. However, it does not recurse any further subdirectories of that section.

@DavePearce
Copy link
Collaborator Author

Based on an analysis of the Makefile, it seems that a simpler strategy would work. Specifically, when a directory is given then recursively include all lisp files within.

@DavePearce DavePearce self-assigned this Jan 9, 2025
@DavePearce DavePearce linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant