Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for broken links #294

Open
Rafellus opened this issue May 30, 2021 · 4 comments
Open

Add testing for broken links #294

Rafellus opened this issue May 30, 2021 · 4 comments

Comments

@Rafellus
Copy link
Contributor

Rafellus commented May 30, 2021

While making the translation for Spanish I found a broken link: Parity Demo-PoA Tutorial. I leave the link in the translation as the task wasn't about changing stuff. But we could use a Github Action to check for broken links on push to master.

@pi0neerpat
Copy link
Collaborator

I think thats a great idea. Is there some existing solution you had in mind?

@Rafellus
Copy link
Contributor Author

Rafellus commented Jun 4, 2021

I check some and after a check to the code, this is a great and simple option: https://github.com/lycheeverse/lychee-action. I'm testing the workflow in my fork, to send a pull request today, with all the config.

@Rafellus
Copy link
Contributor Author

Rafellus commented Jun 4, 2021

Found one that works. This: https://github.com/marketplace/actions/markup-link-checker-mlc

I ran Github Actions in my fork and got great results: https://github.com/Rafellus/ethereum-developer-tools-list/runs/2748708518?check_suite_focus=true. You can find there the workflow YAML file.

Also adding this will be a good opportunity for adding a status badge.

@sirhashalot
Copy link
Contributor

This was fixed by PR #314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants