Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graded Lab 1 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Graded Lab 1 #18

wants to merge 1 commit into from

Conversation

thecardkid
Copy link

@thecardkid thecardkid commented Nov 14, 2016 •
edited
Loading

Overall: 190/200 👍

Proposal 10/10

Turned in one

Wireframes 30/30

Very detailed wireframes.

Final Deliverable 150/160

Functionality 70/70

  • Completion 60/60 You went far beyond the required MVP, and did an excellent job!
  • Bug Free 10/10 Works seamlessly. Well done!

Design/Usability 10/15

See screenshot for why you lost points. Sorry it's so silly, but it's really ugly.
ui

Quality 70/75

  • Git practices 20/20 Did some stalking. Work looks very even. Nice PRs. Nice branches.
  • Good coding practices 15/20 Deducted points here for leaving in some unused variables, empty if statements, and not using strings.xml sometimes
  • Readability 20/20 Superb
  • Even work distribution 15/15 Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thecardkid