Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Role and license acceptance becomes out-of-sync when initializing a revision #138

Open
mmulich opened this issue Nov 20, 2014 · 2 comments
Open

Role and license acceptance becomes out-of-sync when initializing a revision #138

mmulich opened this issue Nov 20, 2014 · 2 comments
Assignees
@mmulich
Labels
bug

Comments

@mmulich
Copy link
Member

mmulich commented Nov 20, 2014

The licensor acceptance is wiped out when trying to revise a published document/binder (aka content). This is the main issue at the moment. Furthermore, if the license changes, all the licensor acceptances should reset.

The greater issue is a bit hairy. It is possible to initialize a revision on already revised content and have that content set all role acceptances to true, even for outstanding or rejected acceptances.

This can be corrected by syncing with publishing during the creation of the revision.
@mmulich mmulich self-assigned this Nov 20, 2014
@reedstrm
Copy link
Member

I think this has been fixed. You'll need to verify, @pumazi

@mmulich mmulich removed the 3 - Code label Dec 5, 2014
@mmulich
Copy link
Member Author

mmulich commented Dec 9, 2014

Looks like this has been partially fixed. However, we are still out-of-sync with the acceptance boolean value and end up paving over the existing one.

mmulich added a commit that referenced this issue Dec 10, 2014
@mmulich
Sync role acceptance with publishing. Addresses #138
89723e1 
This corrects and issue where a revision would not sync up previously
accepted values into the newly created content.
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich
Sync role acceptance with publishing. Addresses #138
f05c1e1 
This corrects and issue where a revision would not sync up previously
accepted values into the newly created content.
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich
Add license acceptance sync for revision creation. Addresses #138
dfbace4 
This will sync the license acceptance with publishing when a revision
is created.
@mmulich mmulich mentioned this issue Dec 11, 2014
Merged
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich @karenc
Sync role acceptance with publishing. Addresses #138
77e3ec7 
This corrects and issue where a revision would not sync up previously
accepted values into the newly created content.
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich @karenc
Add license acceptance sync for revision creation. Addresses #138
b69b8c8 
This will sync the license acceptance with publishing when a revision
is created.
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich
Sync role acceptance with publishing. Addresses #138
b0377d2 
This corrects and issue where a revision would not sync up previously
accepted values into the newly created content.
mmulich added a commit that referenced this issue Dec 11, 2014
@mmulich
Add license acceptance sync for revision creation. Addresses #138
842db99 
This will sync the license acceptance with publishing when a revision
is created.
reedstrm added a commit that referenced this issue Dec 11, 2014
@reedstrm
Merge pull request #164 from Connexions/issue-138
5a7ec0c 
Fix issue #138
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmulich mmulich

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmulich @reedstrm