Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: newPendingTransactions and syncing are not implemented in the fullnode yet. #122

Closed
waelsy123 opened this issue Apr 23, 2023 · 4 comments

Comments

@waelsy123
Copy link

I would like to implement this missing feature:

// eSpace PubSub notification
// TODO:
// 2. newPendingTransactions and syncing are not implemented in the fullnode yet.

could you please provide more details on what needs to be done?

I'm not sure if in general other fullnode send these information so I can retrieve it and provide it by PubSub

@wanliqun
Copy link
Contributor

wanliqun commented Apr 23, 2023

Hi, @waelsy123 Thanks for the interest in contributing to confura.

Conflux is EVM-compatible by providing EVM space. For now, confura serves PubSub requests by delegating a shared proxy connection to the full node.

So please file your issue to our conflux-rust repo for more details.

@waelsy123
Copy link
Author

Hi @wanliqun I just created another issue on conflux-rust: #issue 2672 . let me know please what do you think? and I would be available to implement the feature however I just need some technical guidance / onboarding to achieve the mentioned requirements. :)

@waelsy123
Copy link
Author

waelsy123 commented May 5, 2023

@wanliqun is the pending transactions pool being synced among nodes?

Do other nodes remain unaware of a transaction until it has been committed?

@wanliqun
Copy link
Contributor

wanliqun commented Jun 5, 2023

@waelsy123 Yes, once a transaction submitted to a node, the transaction would be replicated to other nodes within the same cluster group.

@wanliqun wanliqun closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants