New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating directories during Add commands are synchronous #74

Open

Confidenceman02 opened this issue Mar 20, 2024 · 0 comments

Labels

Owner

Confidenceman02 commented Mar 20, 2024 •

edited

Loading

The code for creating directories is synchronous and pretty ugly.

Having an async method would be far better as we could handle and check the operation completed successfully in a more concise fashion.

We could create a Result monad for directory creation effects.

Resources:

The mighty Arjan has a cool video on how to test it: https://www.youtube.com/watch?v=n1nqgMtWRwg

Confidenceman02 added the code smell label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment