Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: mark targets as .PHONY #1785

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Makefile: mark targets as .PHONY #1785

merged 3 commits into from
Aug 19, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Aug 15, 2024

Description

I believe it's easier to remember to mark a target as phony if .PHONY is right above the target.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner August 15, 2024 09:36
@raulb raulb enabled auto-merge (squash) August 19, 2024 13:53
@raulb raulb merged commit 2be6a5e into main Aug 19, 2024
4 checks passed
@raulb raulb deleted the haris/makefile-add-phony branch August 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @raulb