Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Fix flaky test #1891

Closed
raulb opened this issue Oct 9, 2024 · 1 comment · Fixed by #1909
Closed

Bug: Fix flaky test #1891

raulb opened this issue Oct 9, 2024 · 1 comment · Fixed by #1909
Assignees
@raulb
Labels
bug Something isn't working triage Needs to be triaged

Comments

@raulb
Copy link
Member

raulb commented Oct 9, 2024 •
edited
Loading

Bug description

This test seems to be inconsistent on CI

--- FAIL: TestServiceLifecycle_Stop (0.21s)
    --- PASS: TestServiceLifecycle_Stop/user_stop:_graceful (0.10s)
    --- FAIL: TestServiceLifecycle_Stop/user_stop:_forceful (0.11s)

One failure example: https://github.com/ConduitIO/conduit/actions/runs/11253638901/job/31289338760#step:4:1377

Steps to reproduce

Run https://github.com/ConduitIO/conduit/blob/main/.github/workflows/test.yml action and notice how that test occasionally fails.

Version

commit: 579a71b
@raulb raulb added bug Something isn't working triage Needs to be triaged labels Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Triage in Conduit Main Oct 9, 2024
@raulb raulb self-assigned this Oct 9, 2024
@raulb raulb moved this from Triage to In Progress in Conduit Main Oct 9, 2024
@raulb
Copy link
Member Author

raulb commented Oct 11, 2024

Related issue #1801

This was referenced Oct 11, 2024
Closed
Merged
@raulb raulb moved this from In Progress to In Review in Conduit Main Oct 11, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Conduit Main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulb raulb

Labels
bug Something isn't working triage Needs to be triaged
Projects
Conduit Main
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: race condition for force stop ConduitIO/conduit
1 participant
@raulb