Commons #1
Merged
Commons #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt, include csync functions from connector-sdk
hariso
reviewed
Dec 4, 2023
- change github actions dependabot interval to weekly - use goccy/go-json instead of encoding/json - fix comments - add Record.WithSerializer - add benchmark for Record.Clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports code from Conduit and the Conduit Connector SDK into this module so they can be shared in the future between both of them and the Processor SDK which will be introduced in the short future.
I want to call out that the golangci-lint action is now configured to take the version from
go.mod, we should probably introduce this to other projects as well (especially Conduit). This means that dependabot updates the version used in the CI action and we don't have to do anything, unless the linter action fails. (EDIT: here it is ConduitIO/conduit#1300)Closes ConduitIO/conduit#1284