Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point-based frame definition support to the mesh importer #802

Open
adamkewley opened this issue Nov 7, 2023 · 1 comment
Open

Add point-based frame definition support to the mesh importer #802

adamkewley opened this issue Nov 7, 2023 · 1 comment
Labels
blemker-osc-collab model-warping Related to model warping changes

Comments

@adamkewley
Copy link
Collaborator

Similar to how the specialized "Frame Definition"

  • Allows users to define edges in the mesh importer
  • Allows users to define frames w.r.t. those edges
  • "Bakes" the definitions into a standard opensim model format on export (e.g. elildes the edges, which aren't supported)
  • Has support for saving framedefs.toml, for warping workflows
  • Saves to .oscmis, rather than osim, if the user wants the software to actually remember the edges etc (atm, it'll bake an osim file, which isn't quite right)
@adamkewley adamkewley added model-warping Related to model warping changes model-warping-extra Related to warping changes, but a bonus change and removed model-warping-extra Related to warping changes, but a bonus change labels Nov 7, 2023
adamkewley added a commit that referenced this issue Nov 16, 2023
adamkewley added a commit that referenced this issue Nov 17, 2023
adamkewley added a commit that referenced this issue Nov 20, 2023
@adamkewley
Copy link
Collaborator Author

This has been delayed because StationDefinedFrame support was natively integrated into OpenSim itself in:

There are a few outstanding issues with the implementation - namely, that it has issues with chained PhysicalOffsetFrames, and those issues are being separately addressed in the (to-be-merged) PR:

Once those are merged upstream, I have already verified that OSC will be able to use them essentially immediately by building a branch of OSC against those patches:

So the downstream integration steps of putting frame-definition support into the model editor should be more-or-less done. Adding it into the mesh importer is a separate concern, but will require separate engineering step (some are done against this issue) in order for that to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blemker-osc-collab model-warping Related to model warping changes
Projects
None yet
Development

No branches or pull requests

1 participant