Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

CommonMarkEditor doesn't support target attribute on link creation on document insert #24

Closed
jochenwezel opened this issue Sep 30, 2016 · 2 comments

Comments

@jochenwezel
Copy link
Member

jochenwezel commented Sep 30, 2016

The document insertion form shows as follows

image

There are 2 general options available

  1. Hide the line with the dropdown box for the target attribute
  2. CommonMark must support the syntax for adding additional link attributes

For option 1

The data referenced by the token must transport additional details on which properties are supported/unsupported (e.g. in this case, target is NOT supported)

For option 2, one or both of these points must see progress

@cmalbertschw
Copy link
Collaborator

Now we fall back to HTML when target is given. Can this be closed?

@jochenwezel
Copy link
Member Author

yes, it's solved by option 3 ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants