Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer need to tag the commit as per readme #21

Closed
martinbryant opened this issue Jan 5, 2024 · 3 comments
Closed

No longer need to tag the commit as per readme #21

martinbryant opened this issue Jan 5, 2024 · 3 comments

Comments

@martinbryant
Copy link
Contributor

When doing the version 1 release, I did not tag the commit as per the readme so the github action uses the version identified in the AgGrdi.fsproj file to add as a tag

@isaacabraham
Copy link
Member

Is the issue here to update the readme then?

@mattgallagher92
Copy link
Member

The tag isn't for automation, it's to make it easier to identify which commit corresponds to each package version, and to get GitHub to notice that there is a new release:
image

I'll update the README to say that, but I think we should keep the step.

@mattgallagher92
Copy link
Member

mattgallagher92 commented Jan 26, 2024

@martinbryant see #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants