Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issue with halWriteNucleotides (?fix described) #283

Open
lukebharrison opened this issue Oct 12, 2023 · 0 comments
Open

Small issue with halWriteNucleotides (?fix described) #283

lukebharrison opened this issue Oct 12, 2023 · 0 comments

Comments

@lukebharrison
Copy link

Hi,

I was working with the ancestorsML + halWriteNucleotides workflow and was having halWriteNucleotides crash with the following error:
command: halWriteNucleotides test.hal Anc01only.txt

terminate called after throwing an instance of 'hal_exception'
what(): DnaAccess is dirty, flush() should have been called
Aborted (core dumped)

Where Anc01only.txt is the output from ancestorsML with the --printWrites option

I added the following line to halWriteNucleotides.cpp:
after line 60: dnaIt->setBase(newChar);
dnaIt->flush();

This seems to have fixed the problem and halWriteNucleotides seems to be correctly updating the sequence in my HAL file. I am not an expert on the hal package, so I hope this is the correct fix - if not, please advise!

Thanks,

Luke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant