Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional maven repos from pom and document instead #2

Open
scrobbleme opened this issue Jun 29, 2016 · 2 comments
Open

Remove additional maven repos from pom and document instead #2

scrobbleme opened this issue Jun 29, 2016 · 2 comments

Comments

@scrobbleme
Copy link
Member

The problem occurs, when these repositories go offline or send errors for whatever reason, as the build may fail and you have to edit the pom, which is not nice for non-committers. This also may occur, when the packages are used as dependencies itself.

Much better: Add the needed repositories to the documentation and describe how to add them in settings.xml (or Nexus..)

@rwi
Copy link
Member

rwi commented Jun 30, 2016

@scrobbleme I wasn't sure whether it was good idea to add the repositories to the pom ;)
The advantage of having them in the pom is that the source can be built without further configuration. Moreover, the plugin repositories which are required for translating the REST API model can be restricted to the 'mda' profile and are therefore not checked when building without this profile.

The downside are the points you mentioned above. But if one of them occurs can't you just add a working repo (directly or as a mirror) to the settings.xml?

@scrobbleme
Copy link
Member Author

@rwi Yes, it should be possible to create a mirror then. But better let them do it upfront, than let them figuring it out a solution later, when it happens.

Maybe just wait for now and see what happens ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants