Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridSplitter broken in RightToLeft FlowDirection #3646

Closed
4 of 21 tasks
Avid29 opened this issue Dec 26, 2020 · 2 comments · Fixed by #3647
Closed
4 of 21 tasks

GridSplitter broken in RightToLeft FlowDirection #3646

Avid29 opened this issue Dec 26, 2020 · 2 comments · Fixed by #3647
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️ in progress 🚧
Milestone
7.0

Comments

@Avid29
Copy link
Contributor

Avid29 commented Dec 26, 2020

Describe the bug

A clear and concise description of what the bug is.

  • Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:

Steps to Reproduce

  • Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)

Steps to reproduce the behavior:
Create a GridSplitter in a context with a RightToLeft FlowDirection
Adjust the GridSplitter.
Observe the GridSpillter move opposite the curser

Expected behavior

Even when in RightToLeft, the GridSplitter should follow the curser

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

NuGet Package(s):
Microsoft.Toolkit.UWP.UI.Controls

Package Version(s):
7 preview 4

Windows 10 Build Number:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build (build number: )

App min and target version:

  • Fall Creators Update (16299)
  • April 2018 Update (17134)
  • October 2018 Update (17763)
  • May 2019 Update (18362)
  • May 2020 Update (19041)
  • Insider Build (xxxxx)

Device form factor:

  • Desktop
  • Xbox
  • Surface Hub
  • IoT

Visual Studio

  • 2017 (version: )
  • 2019 (version: 16.8.3)
  • 2019 Preview (version: )

## Additional context
Add any other context about the problem here.
@Avid29 Avid29 added the bug 🐛 An unexpected issue that highlights incorrect behavior label Dec 26, 2020
@ghost ghost added the needs triage 🔍 label Dec 26, 2020
@ghost
Copy link

ghost commented Dec 26, 2020

Hello Avid29, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@Avid29 Avid29 mentioned this issue Dec 26, 2020
Merged
8 tasks
@Kyaa-dost
Copy link
Contributor

@Avid29 Thanks for highlighting the issue and creating a PR ❤️

FYI there is also a discussion going on regarding redesigning the API of GridSplitter #2976 which will improve the overall performance of control

@ghost ghost added this to the 7.0 milestone Dec 28, 2020
@ghost ghost added the In-PR 🚀 label Dec 28, 2020
@Avid29 Avid29 changed the title GridSplitter broker in RightToLeft FlowDirection GridSplitter broken in RightToLeft FlowDirection Dec 30, 2020
@ghost ghost added the in progress 🚧 label Dec 30, 2020
@ghost ghost closed this as completed in #3647 Feb 9, 2021
ghost pushed a commit that referenced this issue Feb 9, 2021
[Bug fix] Inverted horizontalChange when in RTL FlowDirection (#3647)
676df13 
<!-- 🚨 Please Do Not skip any instructions and information mentioned below as they are all required and essential to evaluate and test the PR. By fulfilling all the required information you will be able to reduce the volume of questions and most likely help merge the PR faster 🚨 -->

<!-- 📝 It is preferred if you keep the "☑️ Allow edits by maintainers" checked in the Pull Request Template as it increases collaboration with the Toolkit maintainers by permitting commits to your PR branch (only) created from your fork.  This can let us quickly make fixes for minor typos or forgotten StyleCop issues during review without needing to wait on you doing extra work. Let us help you help us! 🎉 -->


## Fixes #3646 
<!-- Add the relevant issue number after the "#" mentioned above (for ex: Fixes #1234) which will automatically close the issue once the PR is merged. -->


<!-- Add a brief overview here of the feature/bug & fix. -->

## PR Type
What kind of change does this PR introduce?
<!-- Please uncomment one or more that apply to this PR. -->

Bugfix 
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## What is the current behavior?
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
In RightToLeft FlowDirection the GridSplitter manipulation moves in the wrong direction.

## What is the new behavior?
<!-- Describe how was this issue resolved or changed? -->
In RightToLeft FlowDirection the GridSplitter manipulation now moves with the mouse


## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [ ] Pull Request has been submitted to the documentation repository [instructions](..\contributing.md#docs). Link: <!-- docs PR link -->
- [ ] Sample in sample app has been added / updated (for bug fixes / features)
    - [ ] Icon has been created (if new sample) following the [Thumbnail Style Guide and templates](https://github.com/windows-toolkit/WindowsCommunityToolkit-design-assets)
- [ ] New major technical changes in the toolkit have or will be added to the [Wiki](https://github.com/windows-toolkit/WindowsCommunityToolkit/wiki) e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
- [ ] Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Header has been added to all new source files (run *build/UpdateHeaders.bat*)
- [x] Contains **NO** breaking changes

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. 
     Please note that breaking changes are likely to be rejected within minor release cycles or held until major versions. -->


## Other information
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Feb 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior Completed 🔥 controls 🎛️ in progress 🚧
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

[Bug fix] Inverted horizontalChange when in RTL FlowDirection
2 participants
@Avid29 @Kyaa-dost