Add Font name/size/color to TextToolbar #4678

stevedeclerck · 2018-03-18T01:39:11Z

stevedeclerck
Mar 18, 2018

I'm submitting a...

Feature request (UserVoice request: )
https://wpdev.uservoice.com/forums/110705-universal-windows-platform/suggestions/33668737-add-font-name-size-color-to-texttoolbar

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Environment

Nuget Package(s): 

Package Version(s): 

Windows 10 Build Number:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Anniversary Update (14393) 
- [ ] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] Insider Build (xxxxx)

Device form factor:
- [ ] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [ ] 2017 (version: )
- [ ] 2017 Preview (version: )

nmetulev · 2018-03-21T03:36:32Z

nmetulev
Mar 21, 2018
Maintainer

Agree, this is a good feature to add. Open to anyone to submit a PR for this.

cc/ @WilliamABradley

0 replies

stevedeclerck · 2018-03-26T11:19:54Z

stevedeclerck
Mar 26, 2018
Author

Hi WIlliam, Thanks a lot. I'm still a novice to UWP programming, but if there is anything I can do, just let me know. Don't want to take advantage of other's people time. Thank you!!!

…

________________________________ Van: Nikola Metulev <[email protected]> Verzonden: woensdag 21 maart 2018 04:36 Aan: Microsoft/UWPCommunityToolkit CC: stevedeclerck; Author Onderwerp: Re: [Microsoft/UWPCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) Agree, this is a good feature to add. Open to anyone to submit a PR for this. cc/ @WilliamABradley<https://github.com/williamabradley> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvWWt7ZYjgxY5rPZFZx52v_mxl5Oaks5tgcrLgaJpZM4SvCOl>.

0 replies

skendrot · 2018-03-26T15:27:41Z

skendrot
Mar 26, 2018
Collaborator

I might have some bandwidth to take this on

0 replies

avknaidu · 2018-04-18T16:39:33Z

avknaidu
Apr 18, 2018

@skendrot are you working on it? How did you add FontFamily as a Dropdown instead of a button?

0 replies

skendrot · 2018-04-18T22:06:59Z

skendrot
Apr 18, 2018
Collaborator

I have not yet had a chance to work on this

0 replies

stevedeclerck · 2018-05-09T14:11:39Z

stevedeclerck
May 9, 2018
Author

Hello, Sorry to ask, I don't want to be annoying or nag, but no news yet on this one? I know everybody is busy and for sure has jobs to do, so I'm just asking. I apologize if it's irritating... Thanks and best regards...

…

________________________________ Van: Shawn Kendrot <[email protected]> Verzonden: donderdag 19 april 2018 00:07 Aan: Microsoft/UWPCommunityToolkit CC: stevedeclerck; Author Onderwerp: Re: [Microsoft/UWPCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) I have not yet had a chance to work on this — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvUn-fZ7210aOKJ7RyE6FwLtcjsPdks5tp7kLgaJpZM4SvCOl>.

0 replies

WilliamABradley · 2018-05-09T14:14:36Z

WilliamABradley
May 9, 2018

@stevedeclerck most people in this toolkit have been unavailable due to the BUILD Conference. I personally have been bogged down with Work and Uni, so I haven't had any time to look into it.

0 replies

stevedeclerck · 2018-05-09T14:16:40Z

stevedeclerck
May 9, 2018
Author

Hi William, Thanks for the feedback, sure I understand, I wish I could help... Thanks !

…

________________________________ Van: William Bradley <[email protected]> Verzonden: woensdag 9 mei 2018 16:14 Aan: Microsoft/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [Microsoft/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) @stevedeclerck<https://github.com/stevedeclerck> most people in this toolkit have been unavailable due to the BUILD Conference. I personally have been bogged down with Work and Uni, so I haven't had any time to look into it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvfqNq1W8Hp9YC9KOKsSG_ejh61RNks5twvnVgaJpZM4SvCOl>.

0 replies

skendrot · 2018-05-09T16:14:57Z

skendrot
May 9, 2018
Collaborator

@stevedeclerck You are free to submit a PR for this issue :)

0 replies

gbarcho · 2018-06-28T13:42:04Z

gbarcho
Jun 28, 2018

@stevedeclerck any update?

0 replies

stevedeclerck · 2018-06-29T09:26:33Z

stevedeclerck
Jun 29, 2018
Author

Hi ! No update yet, I guess everybody is busy? best regards

…

________________________________ Van: gbarcho <[email protected]> Verzonden: donderdag 28 juni 2018 15:42 Aan: Microsoft/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [Microsoft/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) @stevedeclerck<https://github.com/stevedeclerck> any update? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvTgjMQl_29UfG9JJNocqy7C8UhKWks5uBN03gaJpZM4SvCOl>.

0 replies

agneszitte · 2018-10-26T23:40:26Z

agneszitte
Oct 26, 2018

I want to help but which font you are referring to @stevedeclerck ?
For the Labels ? The font of the ToolbarButton ?
Thanks in advance for the feedback :) !

0 replies

nmetulev · 2018-10-26T23:49:15Z

nmetulev
Oct 26, 2018
Maintainer

I believe the idea is to add something like this:

So users can select the font, the font size, or the color of the text

0 replies

agneszitte · 2018-10-27T00:21:36Z

agneszitte
Oct 27, 2018

Thanks a lot for the feedback @nmetulev !
I will check what I can do.

0 replies

agneszitte · 2018-10-27T19:02:04Z

agneszitte
Oct 27, 2018

@nmetulev I started first with an option for the font size with RichText Format.
Since there is no editable ComboBox available for now, I kept it simple and used a ToolbarButton with a Flyout. (cf. #845)

I also added the selection, by keeping the most common text editor behavior :

Nothing is selected means no font sizes selected
Same font size across the selection means the current font size selected
Different font sizes across the selection mean no font sizes selected

Hope it's a good start and happy to receive some feedback ;)

0 replies

nmetulev · 2018-10-28T23:59:21Z

nmetulev
Oct 28, 2018
Maintainer

This is great, thanks for taking this on. I know you mentioned that there is no editable ComboBox yet, but I just noticed there is a IsEditable property added in the latest sdk. I have not used it yet, but sounds like it would be a good candidate for this. For platforms that don't support it, we can just not enable editing.

What do you think?

0 replies

JustinXinLiu · 2018-10-29T00:16:39Z

JustinXinLiu
Oct 29, 2018
Maintainer

Agree with @nmetulev. This would be a perfect example for Conditional XAML. :)

0 replies

stevedeclerck · 2018-10-29T11:07:34Z

stevedeclerck
Oct 29, 2018
Author

Hi, I guess my proposal is not that easy to accomplish, since I guess the toolbar only supports buttons at this time and not a combo. I looked at it myself already, but it don't know how to accomplish it. So, sorry for the hardship... It would be nice like in Office-Word if it's possible to change the font / size and color of the text entered in the richtext field, so text formatting is possible beyond bold or underline... thanks !

…

________________________________ Van: Agnes ZITTE <[email protected]> Verzonden: zaterdag 27 oktober 2018 01:40 Aan: windows-toolkit/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [windows-toolkit/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) I want to help but which font you are referring to @stevedeclerck<https://github.com/stevedeclerck> ? For the Labels ? The font of the ToolbarButton ? Thanks in advance for the feedback :) ! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvf9d75xj-q1RV04kRXOZ1krNwQGjks5uo51ygaJpZM4SvCOl>.

0 replies

stevedeclerck · 2018-10-29T11:08:24Z

stevedeclerck
Oct 29, 2018
Author

Hi, Yes, indeed, and perhaps the color setting of the text? Thanks

…

________________________________ Van: Nikola Metulev <[email protected]> Verzonden: zaterdag 27 oktober 2018 01:49 Aan: windows-toolkit/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [windows-toolkit/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) I believe the idea is to add something like this: [image]<https://user-images.githubusercontent.com/711864/47596934-0384c500-d93f-11e8-9948-ac9f41902f44.png> So users can select the font, the font size, or the color of the text — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvUTgtgYzqpZVNoJ-nr6D8LQeQrvCks5uo5-EgaJpZM4SvCOl>.

0 replies

stevedeclerck · 2018-10-29T11:10:04Z

stevedeclerck
Oct 29, 2018
Author

Hi, looks great, I didn't think of the flyout. I guess it's not needed to be editable. All font sizes are present.. Thanks ! Looks good!

…

________________________________ Van: Agnes ZITTE <[email protected]> Verzonden: zaterdag 27 oktober 2018 21:02 Aan: windows-toolkit/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [windows-toolkit/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) @nmetulev<https://github.com/nmetulev> I started first with an option for the font size with RichText Format. Since there is no editable ComboBox available for now, I kept it simple and used a ToolbarButton with a Flyout. (cf. #845<#845>) I also added the selection, by keeping the most common text editor behavior : * Nothing is selected means no font sizes selected * Same font size across the selection means the current font size selected * Different font sizes across the selection mean no font sizes selected [image]<https://user-images.githubusercontent.com/16295702/47608287-1bb91a80-d9f9-11e8-87df-3cfad2aa0c69.png> Hope it's a good start and happy to receive some feedback ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvQTwdIru6Xghxy776bd1hOB7_RIzks5upK22gaJpZM4SvCOl>.

0 replies

agneszitte · 2018-10-29T12:24:16Z

agneszitte
Oct 29, 2018

Thanks a lot for all the feedback! I have not used it yet for the IsEditable property with the latest SDK for the ComboBox. I will do some tests and see 😉.

0 replies

stevedeclerck · 2018-12-28T09:40:40Z

stevedeclerck
Dec 28, 2018
Author

Hi, I guess no news on this one yet? Thanks and happy newyear....

…

________________________________ Van: Agnes ZITTE <[email protected]> Verzonden: maandag 29 oktober 2018 13:24 Aan: windows-toolkit/WindowsCommunityToolkit CC: stevedeclerck; Mention Onderwerp: Re: [windows-toolkit/WindowsCommunityToolkit] Add Font name/size/color to TextToolbar (#1903) Thanks a lot for all the feedback! I have not used it yet for the IsEditable property with the latest SDK for the ComboBox. I will do some tests and see 😉. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1903 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjwPvfJl6j6ftw8LqSzSdQ3bGQM0PEVhks5upvOIgaJpZM4SvCOl>.

0 replies

mdtauk · 2018-12-28T14:20:37Z

mdtauk
Dec 28, 2018

The Font Name and Size drop downs should use the EditableComboBoxes for quick typing of values. But perhaps the Text Toolbar needs a plain text and rich text mode?

And when will this control be able to move into the CommandFlyout control? As in when does WinUI allow N-1 compatibility.

0 replies

Kyaa-dost · 2020-06-24T19:57:34Z

Kyaa-dost
Jun 24, 2020

@agneszitte-nventive I know it's been way too long but is this work still being done or any update regarding the feasibility of this feature?

0 replies

stevedeclerck · 2020-06-24T20:57:34Z

stevedeclerck
Jun 24, 2020
Author

yeah, way too long 🙂

0 replies

agneszitte · 2020-06-25T14:30:37Z

agneszitte
Jun 25, 2020

@michael-hawker / @Kyaa-dost
I'm sorry I didn't have the time to work on it since.
If anyone wants to work on it they are welcome to do it.
Sorry for the lack of time.

0 replies

Kyaa-dost · 2020-06-25T16:25:06Z

Kyaa-dost
Jun 25, 2020

@agneszitte-nventive no worries! Let's see if any other community member is able to pick this up.

0 replies

stevedeclerck · 2020-06-27T19:57:01Z

stevedeclerck
Jun 27, 2020
Author

I wish I had the knowledge to do it...

0 replies

Add Font name/size/color to TextToolbar #4678

I'm submitting a...

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Environment

Replies: 28 comments

nmetulev Mar 21, 2018 Maintainer

stevedeclerck Mar 26, 2018 Author

skendrot Mar 26, 2018 Collaborator

skendrot Apr 18, 2018 Collaborator

stevedeclerck May 9, 2018 Author

stevedeclerck May 9, 2018 Author

skendrot May 9, 2018 Collaborator

stevedeclerck Jun 29, 2018 Author

nmetulev Oct 26, 2018 Maintainer

nmetulev Oct 28, 2018 Maintainer

JustinXinLiu Oct 29, 2018 Maintainer

stevedeclerck Oct 29, 2018 Author

stevedeclerck Oct 29, 2018 Author

stevedeclerck Oct 29, 2018 Author

stevedeclerck Dec 28, 2018 Author

stevedeclerck Jun 24, 2020 Author

stevedeclerck Jun 27, 2020 Author

nmetulev
Mar 21, 2018
Maintainer

stevedeclerck
Mar 26, 2018
Author

skendrot
Mar 26, 2018
Collaborator

skendrot
Apr 18, 2018
Collaborator

stevedeclerck
May 9, 2018
Author

stevedeclerck
May 9, 2018
Author

skendrot
May 9, 2018
Collaborator

stevedeclerck
Jun 29, 2018
Author

nmetulev
Oct 26, 2018
Maintainer

nmetulev
Oct 28, 2018
Maintainer

JustinXinLiu
Oct 29, 2018
Maintainer

stevedeclerck
Oct 29, 2018
Author

stevedeclerck
Oct 29, 2018
Author

stevedeclerck
Oct 29, 2018
Author

stevedeclerck
Dec 28, 2018
Author

stevedeclerck
Jun 24, 2020
Author

stevedeclerck
Jun 27, 2020
Author