Behavior OnKeyDown

[ArchieCoder]

Hi, today I wanted to remove our custom code in our solution to use the ones from the WCT.

I was surprised to not find the behavior about detecting the Enter key on a TextBox or PasswordBox. This is a familiar UX on Login view.

Here is the code used in our project. Feel free to add it to the WCT.

ExecuteCommandOnKeyDownBehavior.txt

[michael-hawker]

Thanks @ArchieCoder this is a good idea. Though I think it can be more generalized to just be a KeyDownTriggerBehavior, as then the developer could chain into whatever actions they want to perform (like InvokeCommand). Just like the existing EventTriggerBehavior.

This would tie it more into the rest of the Behavior ecosystem. Is this something you'd be interested in making a PR for? I believe we have an example of how to write a TriggerBehaviors in the repo already, it's really just this line that's needed:

WindowsCommunityToolkit/Microsoft.Toolkit.Uwp.UI.Behaviors/Animations/AnimationStartedTriggerBehavior.cs

Line 69 in 1d31e54

Interaction.ExecuteActions(sender, Actions, e);

[ArchieCoder]

Sure.

1- I'm confused why EventTriggerBehavior belongs in https://github.com/microsoft/XamlBehaviors. Should these behaviors be in WCT?

2- AnimationStartedTriggerBehavior or AnimationStartedTriggerBehavior does not have any sample, was it something that was forgotten?

3- Do I just start writting the behavior and I do a PR? Do I need to be included in the github project first?

Thanks

[michael-hawker]

@ArchieCoder thanks! To answer your questions:

1. The EventTriggerBehavior is part of the base behaviors SDK, Behaviors is a separate project outside the Toolkit, we just have our own Behaviors package built on top of it to provide more behaviors for developers for different scenarios.

2. We have our generated doc for it here, though there's not a great example. It's supposed to be attached to an AnimationSet to trigger when it starts/ends as it is named. FYI @Sergio0694

3. Nope, just create a fork of the toolkit, create a new branch, and add the behavior and a sample. Then submit a PR. There's more info about contributing in our Wiki.

[ArchieCoder]

PR submitted. I don't know how to add the documentation. Is it automatically generated?

In the JSON file, I specified: https://raw.githubusercontent.com/MicrosoftDocs/WindowsCommunityToolkitDocs/master/docs/behaviors/KeyboardBehaviors.md