Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Replying to repetitive committable code suggestions using threads #920

Closed
kkc-tonywu opened this issue May 23, 2024 · 3 comments
Labels

Comments

@kkc-tonywu
Copy link

Hello everyone,

First of all, I'd like to express my gratitude to all those involved in integrating this tool with GitLab. So far, it has been working very well.

Whenever the PR-Agent conducts code reviews with commitable_code_suggestions enabled, it generates multiple suggestions. However, upon running the PR-Agent again, there is a chance of regenerating the same suggestions. Is it possible to respond to these repetitive suggestions through a threaded approach?

@mrT23
Copy link
Collaborator

mrT23 commented May 25, 2024

  1. i am not sure what is a "thread" in github (or in gitlab ? bitbucket ?). is that something that is actually supported?

  2. our recommended, and default way, for code suggestions is as a single comment. we introduced a lot of improvements there, including noise reduction, and are planning to keep working on that mode. commitable code suggestions are far too noisy for most users, and that's why we are not prioritizing them. Still, a contribution from the community for committable code suggestions will be welcomed

image

@mrT23 mrT23 added the answered label May 25, 2024
@kkc-tonywu
Copy link
Author

I am referring to the GitLab platform. (Related API: Add note to existing merge request thread)

Because I noticed duplicated and similar code suggestions when using committable code suggestions, we would like to consolidate them under the same thread. This approach will help reduce clutter and streamline categorization.

image

image

commitable code suggestions are far too noisy for most users

I think there are two ways to solve this:

  1. [GITLAB] Aggregate review comments and shoot in 1 as generally the MR review works in Gitlab · Issue #307 · Codium-ai/pr-agent
  2. The notification settings can be adjusted and controlled through the configuration file, designed to be as flexible as possible.

@mrT23
Copy link
Collaborator

mrT23 commented May 28, 2024

you are welcome to open a PR

@mrT23 mrT23 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants