Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision problem #44

Closed
DaGuT opened this issue Mar 29, 2018 · 2 comments
Closed

Collision problem #44

DaGuT opened this issue Mar 29, 2018 · 2 comments

Comments

@DaGuT
Copy link
Contributor

DaGuT commented Mar 29, 2018

Hola! With #43 there is now collision problem. You might not be touching the edge, but you'll loose (currently, there is a rectangle checking, however the image is not rectangled)

Also, in my personal opinion, #40 is better. Also, it's free and made by user and commited at 5c6c6f0 :(
If we'd want to have those normal peaks, then there is a need to change collision (also it should be changed now). Current model is really bad :(

A-Edusei added a commit to A-Edusei/Flappy-Bird-Clone that referenced this issue Apr 6, 2018
This is an edited pipe design for issue CodingTrain#44 addressing the collision problem
A-Edusei added a commit to A-Edusei/Flappy-Bird-Clone that referenced this issue Apr 6, 2018
I have replaced the current pipe design with a slightly altered version which addresses the collision issue pointed out in issue CodingTrain#44. The issue was to do with the transparent section in which the bird/unicorn sprite kept hitting.
@A-Edusei
Copy link
Contributor

A-Edusei commented Apr 6, 2018

Hi apologies for the late response to this issue. I can see the point you have made and have tested it out and as you mentioned there is a collision problem. I believe the issue lies within the transparency field that isn't displaying. With my uploaded design there is a transparent space that hasn't been drawn in causing this issue (I purposely left this space empty mostly due to the aesthetics of the new design of the pipes). As you know all uploaded images by default are uploaded as a square or rectangle transparent background which will still register a "HIT" even without a graphic or drawing within that space. I have come up with a solution which keeps the previous design I uploaded by slightly altering it but get rids of the transparent collision problem

@shiffman
Copy link
Member

shiffman commented Apr 9, 2018

Resolved!

@shiffman shiffman closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants