-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipe design #24
Comments
Maybe #23 fixes this? |
That is a consideration for you to make. I kind of like the design in #23 (given it does what I think it does). I would say it does fix this. In the end this is a case of do you like it or not, if you do: issue closed. |
#25 But suddenly then pipe peak was replaced with normal pipe, I guess that's due to collision problem, however, it's fixed to some point |
The collision detection is still a bit off. Both the "Flappy" train and the pipes have little transparent pieces on their right and left side. To see it better, the following picture shows the first frame of collision with the pipe. We have to either cut the transparent pieces from the pictures or modify the collision detection by some arbitrary numbers (which is probably the worse idea). |
Leaving this open as I think I'd like to implement a custom / original design in case there are copyright issues with the green ones. |
I have addressed the issue raised CodingTrain#24 and have gone ahead to create an original and new pipe design which also fits the theme of the Flappy Bird Clone Game and have ensured to replace the current pipe design with the new design which has been edited in the sketch.js file as well as the graphics folder
I noticed this issue is still open and I've gone ahead to implement some design ideas. I hope these will be suited to the design needs of the game. Issue addressed in #43 |
Resolved! |
They look like maybe they are too close together and too skinny? (As compared to the original game design?)
The text was updated successfully, but these errors were encountered: