Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe design #24

Closed
shiffman opened this issue Mar 9, 2018 · 9 comments
Closed

Pipe design #24

shiffman opened this issue Mar 9, 2018 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@shiffman
Copy link
Member

shiffman commented Mar 9, 2018

They look like maybe they are too close together and too skinny? (As compared to the original game design?)

@shiffman shiffman added enhancement New feature or request help wanted Extra attention is needed labels Mar 9, 2018
@shiffman
Copy link
Member Author

shiffman commented Mar 9, 2018

Maybe #23 fixes this?

@rhbvkleef
Copy link
Contributor

That is a consideration for you to make. I kind of like the design in #23 (given it does what I think it does). I would say it does fix this. In the end this is a case of do you like it or not, if you do: issue closed.

@DaGuT
Copy link
Contributor

DaGuT commented Mar 10, 2018

#25
Done :)

But suddenly then pipe peak was replaced with normal pipe, I guess that's due to collision problem, however, it's fixed to some point

@ZwergB
Copy link

ZwergB commented Mar 12, 2018

The collision detection is still a bit off. Both the "Flappy" train and the pipes have little transparent pieces on their right and left side.

To see it better, the following picture shows the first frame of collision with the pipe.

collision_flappytrain

We have to either cut the transparent pieces from the pictures or modify the collision detection by some arbitrary numbers (which is probably the worse idea).

@DaGuT
Copy link
Contributor

DaGuT commented Mar 13, 2018

#31
Pipe problem is fixed in here with new pipe from some1's commit

Train.... Yeah, may be some1 wants to fix it, idk :)
Okay, I did it #38

@shiffman
Copy link
Member Author

Leaving this open as I think I'd like to implement a custom / original design in case there are copyright issues with the green ones.

@DaGuT
Copy link
Contributor

DaGuT commented Mar 13, 2018

@shiffman #31 there was custom design, It was open for quite a while.
Do it with #40 if you like unicornshmallow :D
Btw, we did that proper drawing just for that design that is not used atm

A-Edusei added a commit to A-Edusei/Flappy-Bird-Clone that referenced this issue Mar 26, 2018
I have addressed the issue raised CodingTrain#24 and have gone ahead to create an original and new pipe design which also fits the theme of the Flappy Bird Clone Game and have ensured to replace the current pipe design with the new design which has been edited in the sketch.js file as well as the graphics folder
@A-Edusei
Copy link
Contributor

I noticed this issue is still open and I've gone ahead to implement some design ideas. I hope these will be suited to the design needs of the game. Issue addressed in #43

@shiffman
Copy link
Member Author

shiffman commented Apr 9, 2018

Resolved!

@shiffman shiffman closed this as completed Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants