From 17423bc360a1b3c1faf3e9127c1d08ab08b0bd2f Mon Sep 17 00:00:00 2001 From: Kai Salmen Date: Mon, 25 Mar 2024 10:45:04 +0100 Subject: [PATCH] doc: implement review comments --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 14f90e1f..6a0c46e6 100644 --- a/README.md +++ b/README.md @@ -32,7 +32,7 @@ Here's the alternative for each options: - `filename`: it can be configured at the webpack level directly - `publicPath`: it can be configured at the webpack level or by hands when redistering the worker in `window.MonacoEnvironment`. -- `languages`: Import vscode language extensions (`@codingame/monaco-vscode-xxx-default-extension`) or (`@codingame/@codingame/monaco-vscode-standalone-*`), but please obey that monaco languages can only be used if `themes` and `textmate` service overrides are not configured. +- `languages`: Import vscode language extensions (`@codingame/monaco-vscode-xxx-default-extension`) or (`@codingame/@codingame/monaco-vscode-standalone-*`). Please obey: VSCode extensions can only be used if `themes` and `textmate` service overrides are configured and monaco languages can only be used if those two services are not configured (see [here](#monaco-standalone-services) for further details). - `features`: With this lib, you can't remove editor features. - `globalAPI`: you can set `window.MonacoEnvironment.globalAPI` to true @@ -91,7 +91,7 @@ At least thoses files should have the headers: - the worker extension host iframe html: `webWorkerExtensionHostIframe.html` - the worker extension host worker javascript: `extensionHost.worker.js` -If adding those headers is not an options, you can have a look at +If adding those headers is not an options, you can have a look at , but only if you are not using webviews as it introduces problems then. # Usage