From 2d76972300382bdbff3bf2c2397c679913bdc0e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Tue, 7 Nov 2023 17:56:32 +0100 Subject: [PATCH 1/6] feat: mark issues as stale and close them automatically --- .github/workflows/stale_issues.yml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 .github/workflows/stale_issues.yml diff --git a/.github/workflows/stale_issues.yml b/.github/workflows/stale_issues.yml new file mode 100644 index 00000000..ef93a76a --- /dev/null +++ b/.github/workflows/stale_issues.yml @@ -0,0 +1,25 @@ +name: Close inactive issues +on: + schedule: + - cron: "30 1 * * *" + +jobs: + close-issues: + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + steps: + - uses: actions/stale@v8 + with: + days-before-issue-stale: 30 + days-before-issue-close: 14 + days-before-pr-stale: 30 + days-before-pr-close: 14 + stale-issue-label: "stale" + stale-pr-label: "stale" + stale-issue-message: "This issue is stale because it has been open for 30 days with no activity." + close-issue-message: "This issue was closed because it has been inactive for 14 days since being marked as stale." + stale-pr-message: "This PR is stale because it has been open for 30 days with no activity." + close-pr-message: "This PR was closed because it has been inactive for 14 days since being marked as stale." + repo-token: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file From e4d61ee9de9fe7c7f85062d2992aabc2b59e7d55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Tue, 7 Nov 2023 17:57:25 +0100 Subject: [PATCH 2/6] doc: fix demo documentation --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 99bb6108..f30f64e2 100644 --- a/README.md +++ b/README.md @@ -364,6 +364,10 @@ It includes: From CLI run: ```bash +# build monaco-vscode-api (the demo use it as a local dependency) +npm ci +npm run build +# start demo cd demo npm ci npm start From 2f5da0417ac678c61655f50d352ac99196734d11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Tue, 7 Nov 2023 17:59:00 +0100 Subject: [PATCH 3/6] fix: missing pure functions --- rollup/rollup.config.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rollup/rollup.config.ts b/rollup/rollup.config.ts index 8c61d3c9..375597e4 100644 --- a/rollup/rollup.config.ts +++ b/rollup/rollup.config.ts @@ -29,6 +29,7 @@ const PURE_FUNCTIONS = new Set([ 'createProxyIdentifier', 'createDecorator', 'localize', + 'localizeWithPath', 'Registry.as', 'Object.freeze', 'URI.parse', @@ -45,6 +46,7 @@ const PURE_FUNCTIONS = new Set([ 'ContextKeyExpr.or', 'ContextKeyExpr.equals', 'ContextKeyExpr.regex', + 'ContextKeyExpr.false', 'ContextKeyNotExpr.create', 'ContextKeyDefinedExpr.create', 'notEqualsTo', From 2405c6c6e98214359a8367e8c1d605bcf47d990c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Tue, 7 Nov 2023 18:00:25 +0100 Subject: [PATCH 4/6] feat: add a way to make any part hidden --- src/service-override/layout.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/service-override/layout.ts b/src/service-override/layout.ts index 551ee776..d9dbd6b0 100644 --- a/src/service-override/layout.ts +++ b/src/service-override/layout.ts @@ -192,7 +192,7 @@ export class LayoutService implements ILayoutService, IWorkbenchLayoutService { return viewContainerModel.activeViewDescriptors.length >= 1 } - setPartHidden (hidden: boolean, part: Exclude): void { + setPartHidden (hidden: boolean, part: Parts): void { if (hidden) { this.hiddenParts.add(part) } else { @@ -226,14 +226,10 @@ export class LayoutService implements ILayoutService, IWorkbenchLayoutService { void this.paneCompositeService.openPaneComposite(panelToOpen, location, true) } } - - // The code that show or hide parts in vscode is not pulled by this library, so let's do it by hands here - // eslint-disable-next-line @typescript-eslint/no-explicit-any - if ((this.paneCompositeService as any).getPartByLocation != null) { - // eslint-disable-next-line @typescript-eslint/no-explicit-any - (this.paneCompositeService as any).getPartByLocation(location).setVisible(!hidden) - } } + + // The code that show or hide parts in vscode is not pulled by this library, so let's do it by hands here + this.getPart(part).setVisible(!hidden) } isVisible (part: Parts): boolean { From 500285db26ca5ca74021a0aa95ca447d0cf17490 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Wed, 8 Nov 2023 10:07:39 +0100 Subject: [PATCH 5/6] doc: add OS compatibility in README --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index f30f64e2..5f294a2d 100644 --- a/README.md +++ b/README.md @@ -380,6 +380,8 @@ For the debug feature, also run: npm run start:debugServer ``` +⚠️ Building monaco-vscode-api is only supported on Linux or Mac. It you use Windows, have a look at [WSL](https://learn.microsoft.com/fr-fr/windows/wsl/install) ⚠️ + #### Remote agent To connect to a remote agent, run: From e09e563aad1e68d1723aebc209e6afc5d272d94b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= Date: Wed, 8 Nov 2023 13:29:55 +0100 Subject: [PATCH 6/6] doc: use language-agnostic url --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5f294a2d..edb71096 100644 --- a/README.md +++ b/README.md @@ -380,7 +380,7 @@ For the debug feature, also run: npm run start:debugServer ``` -⚠️ Building monaco-vscode-api is only supported on Linux or Mac. It you use Windows, have a look at [WSL](https://learn.microsoft.com/fr-fr/windows/wsl/install) ⚠️ +⚠️ Building monaco-vscode-api is only supported on Linux or Mac. It you use Windows, have a look at [WSL](https://learn.microsoft.com/windows/wsl/install) ⚠️ #### Remote agent