[BUGFIX] Fix translations in deletion modals #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a contentElement in the page module (TYPO3
11.5.32
, GridElements11.1.0
), the confirmation modal doesn't respect the language settings of the user. It is also very unspecific, and doesn't explicitly confirm for deletion (and simply asks "Alert: are you sure?")This seems to be caused by the
Header.html
templates, which tries to read a non-existing (or empty) property and falls back to TYPO3 JS defaults in english:I couldn't find anywhere, where
deleteConfirmText
,deleteTitle
ordeleteCancelText
was being set (in both the GridElements extension and in the TYPO3 core), so I assume it was a copy/paste error, or it was an experiment which wasn't implemented until the end.After fetching the translations from the
backend
extension, this is how it looks like:ℹ️ the title and the content are twice the same in German, but this is due to the two strings
label.confirm.delete_record.title
andlabel.confirm.delete_record.content
being identical in that locale.