Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality enhancement - Projects Controller #940

Open
wrspada02 opened this issue Sep 23, 2024 · 0 comments
Open

Code quality enhancement - Projects Controller #940

wrspada02 opened this issue Sep 23, 2024 · 0 comments

Comments

@wrspada02
Copy link
Contributor

Contains too much logic in one place, with some actions not following standard Rails conventions (e.g., reports, ownership, archived).

  • index: Builds a data structure with projects and queries activities using hardcoded values like 1.week.ago.
  • destroy: Contains logic on when a project can be destroyed (valid_name_confirmation?).
  • import: Executes multiple flows and uses hardcoded numbers such as 1.minute and 60.
  • import_upload: Sets session values, updates projects, and schedules background tasks.
  • change_archived: A protected method with too much logic and varied responsibilities.
@wrspada02 wrspada02 changed the title Code quality enhancement - ProjectsController Code quality enhancement - Projects Controller Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant