Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeStyle #16

Closed
rgomezcasas opened this issue Oct 13, 2017 · 4 comments
Closed

Add CodeStyle #16

rgomezcasas opened this issue Oct 13, 2017 · 4 comments
Assignees
@rgomezcasas
Labels
Enhancement Good first issue Good for newcomers

Comments

@rgomezcasas
Copy link
Member

No description provided.

@rgomezcasas rgomezcasas self-assigned this Oct 13, 2017
@JavierCane
Copy link
Member

JavierCane commented Feb 21, 2019 •
edited
Loading

We should add the CodeSniffer rules and check in the make test command, and include also PHP CS Fixer inspections. Or should we replace CodeSniffer by CS Fixer? Does CS Fixer include all we need (PSR-2 and so on)?

@JavierCane JavierCane pinned this issue Feb 21, 2019
@JavierCane JavierCane added the Good first issue Good for newcomers label Feb 24, 2019
@zerai
Copy link

zerai commented Jan 21, 2020

Hi, any news about this open issue?
I don't know CodeSniffer, but I can provide a PR for CS Fixer.
WDYT?

@jeslopcru
Copy link

I'm wondering if you can close this issue because it was solved when codelytv/coding-style was added? and in the Makefile there is a command called lint 🤔
Good job!

@rgomezcasas
Copy link
Member Author

Totally @jeslopcru!!! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgomezcasas rgomezcasas

Labels
Enhancement Good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JavierCane @rgomezcasas @jeslopcru @zerai