Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review in your team #18

Open
5 tasks
SallyMcGrath opened this issue Jul 23, 2024 · 0 comments
Open
5 tasks

Code review in your team #18

SallyMcGrath opened this issue Jul 23, 2024 · 0 comments
Labels
📅 Sprint 1 Assigned during Sprint 1 of this module 📅 Sprint 2 Assigned during Sprint 2 of this module 🎯 Topic Code Review Reading, understanding, and analysing code 🎯 Topic Requirements Interpreting requirements with precision and accuracy 🎯 Topic Teamwork Working productively with other people 🎯 Topic Testing It's important that software works and that people can use it

Comments

@SallyMcGrath
Copy link
Member

Link to the coursework

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

Why are we doing this?

You must set aside a part of your development time to review the work of your team. In your technical interview, you may to asked to discuss a feature written by someone else in your team, so you will need to read and understand it.

How to review

  • Use the GitHub PR interface, either on GitHub or via VSCode
  • Checkout the PR locally gh pr checkout 123 and run the code to make sure it works
  • Test the code using the acceptance criteria on the ticket
  • Ask clarifying questions to make sure you understand the code
  • Offer any fixes or improvements you can see

Maximum time in hours

2

How to get help

Volunteers and other team members can help you with code review. You may choose to spend some time in class doing this together.

How to submit

Submit your review directly on your teammates PR.

@SallyMcGrath SallyMcGrath added 📅 Sprint 1 Assigned during Sprint 1 of this module 📅 Sprint 2 Assigned during Sprint 2 of this module 🎯 Topic Code Review Reading, understanding, and analysing code 🎯 Topic Requirements Interpreting requirements with precision and accuracy 🎯 Topic Teamwork Working productively with other people 🎯 Topic Testing It's important that software works and that people can use it labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📅 Sprint 1 Assigned during Sprint 1 of this module 📅 Sprint 2 Assigned during Sprint 2 of this module 🎯 Topic Code Review Reading, understanding, and analysing code 🎯 Topic Requirements Interpreting requirements with precision and accuracy 🎯 Topic Teamwork Working productively with other people 🎯 Topic Testing It's important that software works and that people can use it
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant